fix: fall back to default value when publicPath is falsy

[manniL]

Types of changes

• Bug fix (a non-breaking change which fixes an issue)
• New feature (a non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves #4364

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly. (PR: #)
• I have added tests to cover my changes (if not applicable, please state why)
• All new and existing tests are passing.

[codecov-io]

Codecov Report

Merging #4365 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev    #4365      +/-   ##
==========================================
+ Coverage   91.53%   91.55%   +0.01%     
==========================================
  Files          56       56              
  Lines        1891     1895       +4     
  Branches      476      477       +1     
==========================================
+ Hits         1731     1735       +4     
  Misses        150      150              
  Partials       10       10

Impacted Files	Coverage Δ
packages/config/src/options.js	94.89% <100%> (+0.15%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27e79be...4e51f3d. Read the comment docs.

[manniL]

Would suggest releasing a patch (details in the linked issue above) after merging.

[pi0]

@manniL I have an alternative way to fix this: We can force add a trailing slash to the publicPath. This not only resolves this bug but also auto-fixes the situations that user forgot to add it.

[manniL]

@pi0 I'd combine both solutions 👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.