New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to disable FriendlyErrorsWebpackPlugin #4498

Merged
merged 3 commits into from Dec 9, 2018

Conversation

Projects
None yet
3 participants
@manniL
Copy link
Member

manniL commented Dec 7, 2018

Provide an option to disable the error overlay

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 7, 2018

Codecov Report

Merging #4498 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4498   +/-   ##
=======================================
  Coverage   91.43%   91.43%           
=======================================
  Files          61       61           
  Lines        2126     2126           
  Branches      516      516           
=======================================
  Hits         1944     1944           
  Misses        167      167           
  Partials       15       15
Impacted Files Coverage Δ
packages/config/src/config/build.js 85.71% <ø> (ø) ⬆️
packages/webpack/src/config/client.js 97.22% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff20bbb...be01307. Read the comment docs.

@manniL manniL requested review from clarkdo and pi0 Dec 7, 2018

Show resolved Hide resolved packages/config/src/config/build.js Outdated

manniL added some commits Dec 9, 2018

@pi0

pi0 approved these changes Dec 9, 2018

@pi0 pi0 merged commit f1b2ca3 into dev Dec 9, 2018

8 of 9 checks passed

[ci.azure] nuxt.js in progress
Details
Semantic Pull Request ready to be squashed
Details
ci/circleci: audit Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
security/snyk - package.json (Atinux) No new issues
Details

@pi0 pi0 deleted the feat-optionally-disable-friendly-errors branch Dec 9, 2018

@pi0

This comment has been minimized.

Copy link
Member

pi0 commented Dec 9, 2018

@manniL Please update the docs when you could 🙏

@manniL

This comment has been minimized.

Copy link
Member

manniL commented Dec 9, 2018

@pi0 will add an issue and update soon ;)

@lock

This comment has been minimized.

Copy link

lock bot commented Jan 8, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 8, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.