feat: mode for plugin

[clarkdo]

Types of changes

• Bug fix (a non-breaking change which fixes an issue)
• New feature (a non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

The idea is from @Atinux , use .server.js or .client.js to automatically detect server/client side plugin.

1. introduce mode: 'client|server' in plugin options
2. deprecate ssr in plugin options and use mode: 'client|server' instead, for now auto adapt ssr: false to mode: 'client' and show deprecating log.
3. apply server/client plugin on file ext like: server.js or client.js (specified options has higher priority)

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly. (PR: #)
• I have added tests to cover my changes (if not applicable, please state why)
• All new and existing tests are passing.

[codecov-io]

Codecov Report

Merging #4592 into dev will increase coverage by 0.04%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##              dev    #4592      +/-   ##
==========================================
+ Coverage   91.02%   91.07%   +0.04%     
==========================================
  Files          61       61              
  Lines        2196     2208      +12     
  Branches      527      533       +6     
==========================================
+ Hits         1999     2011      +12     
+ Misses        179      178       -1     
- Partials       18       19       +1

Impacted Files	Coverage Δ
packages/core/src/module.js	100% <ø> (ø)	⬆️
packages/builder/src/builder.js	96.7% <100%> (+0.23%)	⬆️
packages/webpack/src/builder.js	93.68% <66.66%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fd059d...2ade565. Read the comment docs.

[clarkdo]

Will add a pr for doc

[Atinux]

This is awesome @clarkdo

[curtisbelt]

@clarkdo Hello, I am using nuxt-edge while project is in development, and after updating to a more recent commit, none of my plugins load when using nuxt start, but they work fine when using nuxt dev.

I did some trial and error, moving backwards through available nuxt-edge versions, and determined that the problem starts after this feature was merged. The issue still exists as of 2.4.0-25768669.8786ff73 (8786ff7).

I did not create a reduced test since I am curious if you will simply reproduce bug right away when using nuxt start. If you are unable to reproduce, I am happy to do more research. Thank you!

[clarkdo]

@curtisbelt I’ll look into it, thank you for the reporting 🙏

[clarkdo]

Hi @curtisbelt Is your plugin specified ssr:false or the file extension is.client/server.js ? If yes, it won’t be loaded in server side

[manniL]

@clarkdo I experience the same on latest nuxt edge for https://github.com/Developmint/developmint.de

[pi0]

I'm wondering how the tests are passing. It may be a breaking change for some special usage. @manniL @curtisbelt could you please help to reproduce it?

[manniL]

@clarkdo You need modern: 'server' set to trigger the wrong behavior.

nuxt.config.js

module.exports = {
  modern: 'server',
  plugins: [
    { src: '~/plugins/test', ssr: false }
  ]
}

plugins/test.js

window.test = true
console.log('TRIGGERED')

I can confirm that it works before #4592 (latest working version: nuxt-edge@2.4.0-25754270.4fb220c9)

[manniL]

Update: fix @ #4659