Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ts): fix default `tsconfig.json` #4842

Merged
merged 1 commit into from Jan 23, 2019

Conversation

Projects
None yet
3 participants
@kevinmarrec
Copy link
Member

commented Jan 23, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

(default refers to @nuxt/typescript/tsconfig.json)
(final refers to generated end-user-project/tsconfig.json)

The following PR does the following fixes and improvements:

  • Remove baseUrl in final tsconfig.json as it's only required for our testing suites
  • Remove resolveJsonModule as , after little thoughts, we should not force it to users
  • Move types property from default to final tsconfig.json as there is an issue if end-user wants to add other types in the array (It overrides the whole array if set after extending default tsconfig.json)
  • Remove logic in packages/typescript/package.js as it's no longer needed
  • Update TypeScript examples to match the above changes
  • Update test/unit/typescript.setup.js to match the above changes
  • Rename a test name in test/unit/typescript.modern.js just for better understanding

Checklist

  • I have updated tests to cover my changes
  • All updated and existing tests are passing

@kevinmarrec kevinmarrec self-assigned this Jan 23, 2019

@kevinmarrec kevinmarrec requested a review from pi0 Jan 23, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jan 23, 2019

Codecov Report

Merging #4842 into dev will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4842      +/-   ##
==========================================
+ Coverage   91.18%   91.22%   +0.04%     
==========================================
  Files          73       73              
  Lines        2360     2360              
  Branches      582      582              
==========================================
+ Hits         2152     2153       +1     
+ Misses        190      189       -1     
  Partials       18       18
Impacted Files Coverage Δ
packages/typescript/src/config-generation.js 57.14% <ø> (ø) ⬆️
packages/vue-renderer/src/renderer.js 95.1% <0%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2184df4...52d7d27. Read the comment docs.

@pi0

pi0 approved these changes Jan 23, 2019

@pi0 pi0 merged commit c39cf84 into nuxt:dev Jan 23, 2019

9 of 10 checks passed

[ci.azure] nuxt.js #20190123.33 failed
Details
Semantic Pull Request ready to be squashed
Details
ci/circleci: audit Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint-app Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-types Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details

@kevinmarrec kevinmarrec deleted the kevinmarrec:fix-default-tsconfig branch Jan 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.