Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert templateFiles name #4924

Merged
merged 1 commit into from Feb 1, 2019

Conversation

@clarkdo
Copy link
Member

clarkdo commented Feb 1, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Revert the variable name for preventing breaking change.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.
@clarkdo clarkdo requested a review from pi0 Feb 1, 2019
@pi0
pi0 approved these changes Feb 1, 2019
@pi0 pi0 merged commit f70645e into nuxt:dev Feb 1, 2019
1 of 3 checks passed
1 of 3 checks passed
[ci.azure] nuxt.js in progress
Details
ci/circleci: setup CircleCI is running your tests
Details
Semantic Pull Request ready to be squashed
Details
@manniL

This comment has been minimized.

Copy link
Member

manniL commented Feb 1, 2019

(Just for transparency: This is a fix for an unreleased change. It won't be backported)

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 1, 2019

Codecov Report

Merging #4924 into dev will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4924      +/-   ##
==========================================
- Coverage   91.87%   91.74%   -0.13%     
==========================================
  Files          73       73              
  Lines        2412     2412              
  Branches      593      593              
==========================================
- Hits         2216     2213       -3     
- Misses        178      181       +3     
  Partials       18       18
Impacted Files Coverage Δ
packages/builder/src/builder.js 88.98% <ø> (ø) ⬆️
packages/vue-renderer/src/renderer.js 94.56% <0%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb13b41...0dc855d. Read the comment docs.

@pi0 pi0 mentioned this pull request Mar 14, 2019
@clarkdo clarkdo deleted the clarkdo:templateFiles branch Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.