Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): fix `getNuxtChildComponents` method #4969

Merged
merged 1 commit into from Feb 7, 2019

Conversation

Projects
None yet
5 participants
@skyrpex
Copy link
Contributor

skyrpex commented Feb 6, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

The getNuxtChildComponents method throws an error if $child.$vnode is undefined. I'm not sure what makes the child to not have an vnode, but it's happening to me when using the a-dropdown component from ant-design-vue and using nuxt-links. If a reproduction is necessary, I guess I could spend some time creating it, but I hope it isn't needed in this case! 馃檹

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 6, 2019

Codecov Report

Merging #4969 into 2.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.x    #4969   +/-   ##
=======================================
  Coverage   91.32%   91.32%           
=======================================
  Files          71       71           
  Lines        2363     2363           
  Branches      584      584           
=======================================
  Hits         2158     2158           
  Misses        187      187           
  Partials       18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 1be455f...b8d9d8a. Read the comment docs.

@manniL manniL assigned clarkdo and pi0 Feb 6, 2019

@pi0

pi0 approved these changes Feb 6, 2019

@clarkdo clarkdo merged commit dbf7099 into nuxt:2.x Feb 7, 2019

9 checks passed

Semantic Pull Request ready to be squashed
Details
ci/circleci: audit Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint-app Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-types Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
@clarkdo

This comment has been minimized.

Copy link
Collaborator

clarkdo commented Feb 7, 2019

@skyrpex Thanks

@skyrpex

This comment has been minimized.

Copy link
Contributor Author

skyrpex commented Feb 7, 2019

You're welcome. Nuxt is an amazing product.

@skyrpex skyrpex deleted the skyrpex:patch-1 branch Feb 7, 2019

@manniL

This comment has been minimized.

Copy link
Member

manniL commented Feb 21, 2019

@clarkdo We should pick that one for the next fix release too 馃構

@clarkdo

This comment has been minimized.

Copy link
Collaborator

clarkdo commented Feb 21, 2019

Sure

This pr was for 2.x, so no need to pick 馃槃

@manniL

This comment has been minimized.

Copy link
Member

manniL commented Feb 21, 2019

@clarkdo Whooops, true 馃槀

@pi0 pi0 referenced this pull request Feb 25, 2019

Closed

chore(release): v2.4.4 #5109

@pi0 pi0 referenced this pull request Mar 14, 2019

Merged

v2.5.0 #5237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.