Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hotfix): preload modern resource in spa modern mode #5043

Merged
merged 1 commit into from Feb 15, 2019

Conversation

Projects
None yet
2 participants
@clarkdo
Copy link
Collaborator

clarkdo commented Feb 15, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested a review from pi0 Feb 15, 2019

@clarkdo

This comment has been minimized.

Copy link
Collaborator Author

clarkdo commented Feb 15, 2019

@pi0 The audit error comes from v3.13.0 which has been fixed in v3.13.0

@pi0

pi0 approved these changes Feb 15, 2019

@clarkdo clarkdo merged commit 3516580 into nuxt:2.x Feb 15, 2019

8 of 9 checks passed

ci/circleci: audit Your tests failed on CircleCI
Details
Semantic Pull Request ready to be squashed
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint-app Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-types Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details

@pi0 pi0 referenced this pull request Feb 25, 2019

Closed

chore(release): v2.4.4 #5109

@pi0 pi0 referenced this pull request Mar 14, 2019

Merged

v2.5.0 #5237

@clarkdo clarkdo deleted the clarkdo:spa-preload branch Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.