Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt-ts): error catch in nuxt-ts binary #5086

Merged
merged 2 commits into from Feb 25, 2019

Conversation

Projects
None yet
5 participants
@kevinmarrec
Copy link
Member

kevinmarrec commented Feb 21, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fixes #4897

@kevinmarrec kevinmarrec changed the title fix: nuxt-ts binary error catch fix: error catch in nuxt-ts binary Feb 21, 2019

@kevinmarrec kevinmarrec requested a review from nuxt/core-team Feb 21, 2019

@kevinmarrec kevinmarrec referenced this pull request Feb 21, 2019

Merged

refactor: better DX for TypeScript support #5079

4 of 6 tasks complete
@Atinux

Atinux approved these changes Feb 21, 2019

@Atinux

This comment has been minimized.

Copy link
Member

Atinux commented Feb 21, 2019

Failing tests apparently @kevinmarrec

@manniL

This comment has been minimized.

Copy link
Member

manniL commented Feb 21, 2019

@kevinmarrec extra space as it seems(it )
image

@kevinmarrec

This comment has been minimized.

Copy link
Member Author

kevinmarrec commented Feb 21, 2019

@manniL I didn't change anything that could make tests fail this way, issue should be on 2.x 🤷‍♀️

@manniL

This comment has been minimized.

Copy link
Member

manniL commented Feb 21, 2019

@clarkdo

This comment has been minimized.

Copy link
Collaborator

clarkdo commented Feb 21, 2019

I manually fixed this in dev branch by 3dd1a28

You can do in same way.

@kevinmarrec

This comment has been minimized.

Copy link
Member Author

kevinmarrec commented Feb 21, 2019

Thanks @clarkdo , I cherry-picked you commit to fix the snapshot through this PR

EDIT : I still don't know about the audit job failing though

@pi0

This comment has been minimized.

Copy link
Member

pi0 commented Feb 23, 2019

Audit is regarding jest > braces. Should be fixed after next minor release (dev ~> 2.x)

@manniL manniL referenced this pull request Feb 25, 2019

Closed

chore(release): v2.4.4 #5109

@Atinux Atinux changed the title fix: error catch in nuxt-ts binary fix(nuxt-ts): error catch in nuxt-ts binary Feb 25, 2019

@Atinux Atinux merged commit 4f887f6 into nuxt:2.x Feb 25, 2019

8 of 9 checks passed

ci/circleci: audit Your tests failed on CircleCI
Details
Semantic Pull Request ready to be squashed
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint-app Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-types Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details

@pi0 pi0 referenced this pull request Mar 14, 2019

Merged

v2.5.0 #5237

@kevinmarrec kevinmarrec deleted the kevinmarrec:hotfix-nuxt-ts-to-2.x branch Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.