Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vue-app): suppress deprecated warning for production #5137

Merged
merged 1 commit into from Mar 1, 2019

Conversation

Projects
None yet
4 participants
@sugarshin
Copy link
Contributor

commented Mar 1, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fixes #5136
We should not need this warning in the production build.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@sugarshin sugarshin force-pushed the sugarshin:suppress-log branch from f368b0b to 7bc114d Mar 1, 2019

@sugarshin

This comment has been minimized.

Copy link
Contributor Author

commented Mar 1, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Mar 1, 2019

Codecov Report

Merging #5137 into dev will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev   #5137      +/-   ##
=========================================
- Coverage   95.08%     95%   -0.09%     
=========================================
  Files          72      72              
  Lines        2421    2421              
  Branches      614     614              
=========================================
- Hits         2302    2300       -2     
- Misses         99     101       +2     
  Partials       20      20
Impacted Files Coverage Δ
packages/vue-renderer/src/renderer.js 94.81% <0%> (-1.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83db959...f8eb8e2. Read the comment docs.

@manniL

This comment has been minimized.

Copy link
Member

commented Mar 1, 2019

Hey 👋 Thanks for the contribution Left you some comments :)

@@ -14,7 +14,7 @@ void (function updateModules() {
<% return true }}) %>

// If store is an exported method = classic mode (deprecated)
if (typeof store === 'function') {
if (typeof store === 'function' && process.env.NODE_ENV !== 'production') {

This comment has been minimized.

Copy link
@manniL

manniL Mar 1, 2019

Member

Better use <% if (isDev) { %> so it's not included in the bundle itself ☺️

This comment has been minimized.

Copy link
@sugarshin

sugarshin Mar 1, 2019

Author Contributor

Thank you for your feedback! I fixed it!

@sugarshin sugarshin force-pushed the sugarshin:suppress-log branch from f669dd8 to 2765ac3 Mar 1, 2019

@manniL manniL self-requested a review Mar 1, 2019

@manniL

This comment has been minimized.

Copy link
Member

commented Mar 1, 2019

LGTM ☺️

@sugarshin sugarshin force-pushed the sugarshin:suppress-log branch from 5c6642a to f8eb8e2 Mar 1, 2019

@sugarshin

This comment has been minimized.

Copy link
Contributor Author

commented Mar 1, 2019

Thank you 🙏 please merge it.

@manniL manniL requested a review from pi0 Mar 1, 2019

@pi0 pi0 changed the title fix: suppress deprecated warning for production chore: suppress deprecated warning for production Mar 1, 2019

@pi0

pi0 approved these changes Mar 1, 2019

@pi0 pi0 changed the title chore: suppress deprecated warning for production chore(vue-app) suppress deprecated warning for production Mar 1, 2019

@pi0 pi0 changed the title chore(vue-app) suppress deprecated warning for production chore(vue-app): suppress deprecated warning for production Mar 1, 2019

@pi0 pi0 merged commit f39205a into nuxt:dev Mar 1, 2019

10 checks passed

Semantic Pull Request ready to be squashed
Details
[ci.azure] nuxt.js #20190301.8 succeeded
Details
ci/circleci: audit Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint-app Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-types Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details

@sugarshin sugarshin deleted the sugarshin:suppress-log branch Mar 2, 2019

@pi0 pi0 referenced this pull request Mar 14, 2019

Merged

v2.5.0 #5237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.