Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples(vue-apollo): use spa mode #5333

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@mingderwang
Copy link

commented Mar 22, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.
@codecov-io

This comment has been minimized.

Copy link

commented Mar 22, 2019

Codecov Report

Merging #5333 into dev will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev    #5333      +/-   ##
=========================================
- Coverage   95.7%   95.66%   -0.04%     
=========================================
  Files         74       74              
  Lines       2513     2513              
  Branches     639      639              
=========================================
- Hits        2405     2404       -1     
- Misses        91       92       +1     
  Partials      17       17
Impacted Files Coverage Δ
packages/vue-renderer/src/renderer.js 91.58% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d7757b...c0bcd0b. Read the comment docs.

2 similar comments
@codecov-io

This comment has been minimized.

Copy link

commented Mar 22, 2019

Codecov Report

Merging #5333 into dev will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev    #5333      +/-   ##
=========================================
- Coverage   95.7%   95.66%   -0.04%     
=========================================
  Files         74       74              
  Lines       2513     2513              
  Branches     639      639              
=========================================
- Hits        2405     2404       -1     
- Misses        91       92       +1     
  Partials      17       17
Impacted Files Coverage Δ
packages/vue-renderer/src/renderer.js 91.58% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d7757b...c0bcd0b. Read the comment docs.

@codecov-io

This comment has been minimized.

Copy link

commented Mar 22, 2019

Codecov Report

Merging #5333 into dev will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev    #5333      +/-   ##
=========================================
- Coverage   95.7%   95.66%   -0.04%     
=========================================
  Files         74       74              
  Lines       2513     2513              
  Branches     639      639              
=========================================
- Hits        2405     2404       -1     
- Misses        91       92       +1     
  Partials      17       17
Impacted Files Coverage Δ
packages/vue-renderer/src/renderer.js 91.58% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d7757b...c0bcd0b. Read the comment docs.

@pi0 pi0 changed the title fix yarn dev problem, window is not defined examples(vue-apollo): use spa mode Mar 22, 2019

@pi0 pi0 requested a review from Atinux Mar 22, 2019

@pi0 pi0 closed this in #5345 Mar 23, 2019

@pi0

This comment has been minimized.

Copy link
Member

commented Mar 23, 2019

Fixed by @aldarund in #5345. @mingderwang Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.