Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): disable loading `babel.config.js` by default #5365

Merged
merged 1 commit into from Mar 24, 2019

Conversation

@clarkdo
Copy link
Member

clarkdo commented Mar 24, 2019

If it's reasonable and qualified to be a hotfix, please change base to 2.x

@clarkdo clarkdo requested a review from pi0 Mar 24, 2019
@pi0

This comment has been minimized.

Copy link
Member

pi0 commented Mar 24, 2019

@Clark Currently dev is in hotfix mode. Thanks for the PR 😍

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 24, 2019

Codecov Report

Merging #5365 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5365   +/-   ##
=======================================
  Coverage   96.04%   96.04%           
=======================================
  Files          74       74           
  Lines        2529     2529           
  Branches      640      640           
=======================================
  Hits         2429     2429           
  Misses         84       84           
  Partials       16       16
Impacted Files Coverage Δ
packages/config/src/config/build.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb5cb40...b5a549d. Read the comment docs.

@pi0
pi0 approved these changes Mar 24, 2019
@pi0 pi0 changed the title fix: disable babel.config.js scanning by default fix(build): disable `babel.config.js` by default Mar 24, 2019
@pi0 pi0 merged commit 64fa424 into nuxt:dev Mar 24, 2019
10 checks passed
10 checks passed
Semantic Pull Request ready to be squashed
Details
[ci.azure] nuxt.js #20190324.16 succeeded
Details
ci/circleci: audit Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint-app Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-types Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
@pi0 pi0 changed the title fix(build): disable `babel.config.js` by default fix(build): disable loading `babel.config.js` by default Mar 24, 2019
@pi0 pi0 mentioned this pull request Mar 24, 2019
@clarkdo clarkdo deleted the clarkdo:disable-babel-config-js branch Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.