Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upfeat(cli): add internal `_generate` and `_build` flags #5434
Conversation
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Apr 1, 2019
•
Codecov Report
@@ Coverage Diff @@
## dev #5434 +/- ##
==========================================
- Coverage 96.16% 96.12% -0.04%
==========================================
Files 74 74
Lines 2555 2555
Branches 650 650
==========================================
- Hits 2457 2456 -1
- Misses 82 83 +1
Partials 16 16
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pi0 commentedApr 1, 2019
•
edited
Types of changes
Description
Previously we had internal flag
options._start
, this PR also addsoptions._build
andoptions._generate
when running CLI commands so 1) options.js 2) modules can predict if a builder or generator is supposed to be started with the current instance. (Useful for #5354.)Checklist: