Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add internal `_generate` and `_build` flags #5434

Merged
merged 2 commits into from Apr 1, 2019
Merged

feat(cli): add internal `_generate` and `_build` flags #5434

merged 2 commits into from Apr 1, 2019

Conversation

@pi0
Copy link
Member

pi0 commented Apr 1, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Previously we had internal flag options._start, this PR also adds options._build and options._generate when running CLI commands so 1) options.js 2) modules can predict if a builder or generator is supposed to be started with the current instance. (Useful for #5354.)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.
@pi0 pi0 requested review from manniL and nuxt/core-team Apr 1, 2019
@pi0 pi0 changed the title feat(cli): add internal _generate and _build options feat(cli): add internal `_generate` and `_build` options Apr 1, 2019
@pi0 pi0 changed the title feat(cli): add internal `_generate` and `_build` options feat(cli): add internal `_generate` and `_build` flags Apr 1, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 1, 2019

Codecov Report

Merging #5434 into dev will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5434      +/-   ##
==========================================
- Coverage   96.16%   96.12%   -0.04%     
==========================================
  Files          74       74              
  Lines        2555     2555              
  Branches      650      650              
==========================================
- Hits         2457     2456       -1     
- Misses         82       83       +1     
  Partials       16       16
Impacted Files Coverage Δ
packages/cli/src/commands/generate.js 91.3% <100%> (ø) ⬆️
packages/cli/src/commands/build.js 86.36% <100%> (ø) ⬆️
packages/cli/src/commands/dev.js 84.61% <100%> (ø) ⬆️
packages/vue-renderer/src/renderer.js 95.56% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 583e32a...2e4343b. Read the comment docs.

@Atinux
Atinux approved these changes Apr 1, 2019
Sébastien Chopin
@pi0 pi0 merged commit 516aea3 into dev Apr 1, 2019
9 of 10 checks passed
9 of 10 checks passed
[ci.azure] nuxt.js in progress
Details
Semantic Pull Request ready to be squashed
Details
ci/circleci: audit Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint-app Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-types Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
@pi0 pi0 deleted the feat/cli-flag branch Apr 1, 2019
@pi0 pi0 mentioned this pull request Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.