Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builder): watch for `pages/` creation when default page displayed #5753

Merged
merged 6 commits into from May 23, 2019

Conversation

@Atinux
Copy link
Member

Atinux commented May 16, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Same as store/ but applied for pages/ creation.

Checklist:

  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 16, 2019

Codecov Report

Merging #5753 into dev will decrease coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev   #5753      +/-   ##
=========================================
- Coverage   95.64%   95.6%   -0.04%     
=========================================
  Files          82      82              
  Lines        2661    2663       +2     
  Branches      682     683       +1     
=========================================
+ Hits         2545    2546       +1     
- Misses         98      99       +1     
  Partials       18      18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.65% <0%> (-0.04%) ⬇️
#unit 92.56% <66.66%> (-0.04%) ⬇️
Impacted Files Coverage Δ
packages/builder/src/builder.js 99.6% <66.66%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a764e1f...828ab16. Read the comment docs.

@pi0 pi0 changed the title fix(builder): Watch for pages/ creation when default page displayed fix(builder): watch for `pages/` creation when default page displayed May 19, 2019
@pi0 pi0 referenced this pull request May 19, 2019
Atinux added 3 commits May 21, 2019
@Atinux Atinux requested review from pi0 and clarkdo May 21, 2019
@pi0
pi0 approved these changes May 23, 2019
@pi0 pi0 merged commit e75d65b into dev May 23, 2019
10 checks passed
10 checks passed
Semantic Pull Request ready to be squashed
Details
[ci.azure] nuxt.js #20190523.16 succeeded
Details
ci/circleci: audit Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint-app Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-types Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
@pi0 pi0 deleted the fix/pages-watch branch May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.