Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-renderer): add vary header for user-agent in modern server mode #5807

Merged
merged 2 commits into from May 25, 2019

Conversation

@pi0
Copy link
Member

pi0 commented May 25, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

When running in modern server mode, our response varies depending on user-agent. A reverse-proxy may wrongly cache the modern/legacy response and use it for others. This PR tries to prevent that.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.
@pi0 pi0 requested a review from clarkdo May 25, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 25, 2019

Codecov Report

Merging #5807 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5807      +/-   ##
==========================================
+ Coverage   95.67%   95.68%   +<.01%     
==========================================
  Files          82       82              
  Lines        2682     2686       +4     
  Branches      687      688       +1     
==========================================
+ Hits         2566     2570       +4     
  Misses         98       98              
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.33% <0%> (-0.08%) ⬇️
#unit 92.66% <100%> (+0.01%) ⬆️
Impacted Files Coverage Δ
packages/vue-renderer/src/renderers/modern.js 98.33% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0958f0...e6a7369. Read the comment docs.

@pi0 pi0 merged commit 7e50fe7 into dev May 25, 2019
10 checks passed
10 checks passed
Semantic Pull Request ready to be squashed
Details
[ci.azure] nuxt.js #20190525.13 succeeded
Details
ci/circleci: audit Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint-app Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-types Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
@pi0 pi0 deleted the fix/modern-vary branch May 25, 2019
@pi0 pi0 mentioned this pull request May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.