Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): fix position of the build indicator when page scrolled #5890

Merged
merged 1 commit into from Jun 6, 2019
Merged

fix(vue-app): fix position of the build indicator when page scrolled #5890

merged 1 commit into from Jun 6, 2019

Conversation

rchl
Copy link

@rchl rchl commented Jun 6, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

When page was scrolled, build indicator would scroll up with the page or end up completely outside of viewport. Use position: fixed to make it stick to the corner.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

codecov-io commented Jun 6, 2019

Codecov Report

Merging #5890 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5890   +/-   ##
=======================================
  Coverage   95.68%   95.68%           
=======================================
  Files          82       82           
  Lines        2689     2689           
  Branches      690      690           
=======================================
  Hits         2573     2573           
  Misses         98       98           
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.35% <ø> (ø) ⬆️
#unit 92.67% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ec02a6...4a198e1. Read the comment docs.

@pi0 pi0 merged commit 0e29653 into nuxt:dev Jun 6, 2019
@rchl rchl deleted the fix/build-indicator-position branch June 6, 2019 21:24
@pi0 pi0 mentioned this pull request Jun 7, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants