Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modulepreload warnings #6118

Merged
merged 4 commits into from Jul 24, 2019

Conversation

@dbachko
Copy link
Contributor

dbachko commented Jul 24, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves #6117

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 24, 2019

Codecov Report

Merging #6118 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #6118      +/-   ##
==========================================
+ Coverage   95.74%   95.75%   +<.01%     
==========================================
  Files          80       80              
  Lines        2658     2659       +1     
  Branches      682      682              
==========================================
+ Hits         2545     2546       +1     
  Misses         97       97              
  Partials       16       16
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.88% <0%> (-0.02%) ⬇️
#unit 92.44% <100%> (ø) ⬆️
Impacted Files Coverage Δ
packages/vue-renderer/src/renderers/spa.js 87.69% <100%> (+0.19%) ⬆️
packages/server/src/middleware/nuxt.js 97.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6f0f5d...a419ad1. Read the comment docs.

@dbachko dbachko changed the title Fixes #6117 modulepreload warnings fix: modulepreload warnings (#6117) Jul 24, 2019
@dbachko dbachko changed the title fix: modulepreload warnings (#6117) fix: modulepreload warnings Jul 24, 2019
@pi0 pi0 requested a review from clarkdo Jul 24, 2019
@pi0 pi0 mentioned this pull request Jul 24, 2019
Copy link
Member

clarkdo left a comment

Really good catch, thank you so much

packages/server/src/middleware/nuxt.js Outdated Show resolved Hide resolved
dbachko and others added 2 commits Jul 24, 2019
@clarkdo clarkdo merged commit 76b1167 into nuxt:dev Jul 24, 2019
9 checks passed
9 checks passed
Semantic Pull Request ready to be squashed
Details
[ci.azure] nuxt.js #20190724.24 succeeded
Details
ci/circleci: audit Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint-app Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
@clarkdo

This comment has been minimized.

Copy link
Member

clarkdo commented Jul 24, 2019

@dbachko Thanks!

Atinux added a commit that referenced this pull request Jul 30, 2019
pi0 added a commit that referenced this pull request Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.