feat(cli, config): `cli.bannerColor` option #6399

danielroe · 2019-09-11T19:27:06Z

Types of changes

Bug fix (a non-breaking change which fixes an issue)
New feature (a non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Description

This exposes a build.bannerColor option to change the color of the Nuxt title in the CLI banner.

Resolves: #6397

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly. (PR: #)
I have added tests to cover my changes
I think that might be overkill for a simple cosmetic change
All new and existing tests are passing.


        feat(cli): display blue 'Nuxt' banner if running with TS

Closes #6397


        fix(cli): remove extra semicolon and test extensions 😳

codecov-io · 2019-09-11T19:58:24Z

Codecov Report

Merging #6399 into dev will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev    #6399      +/-   ##
==========================================
+ Coverage   95.65%   95.65%   +<.01%     
==========================================
  Files          79       79              
  Lines        2692     2693       +1     
  Branches      696      696              
==========================================
+ Hits         2575     2576       +1     
  Misses        101      101              
  Partials       16       16

Flag	Coverage Δ
#e2e	`100% <ø> (ø)`	⬆️
#fixtures	`50.68% <0%> (-0.02%)`	⬇️
#unit	`92.35% <100%> (ø)`	⬆️

Impacted Files	Coverage Δ
packages/config/src/config/cli.js	`100% <ø> (ø)`	⬆️
packages/cli/src/utils/banner.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 686720f...a42432d. Read the comment docs.

pi0

We don't include typescript logic here. It may be better an option to customize color.


        Merge remote-tracking branch 'upstream/dev' into add-blue-for-typescript


        feat(cli, config): add ability to customize title color


        test(config): update config snapshots


        fix(cli): test presence of build.ui in options


        Merge branch 'dev' into add-blue-for-typescript

danielroe · 2019-09-26T12:57:15Z

We don't include typescript logic here. It may be better an option to customize color.

I've exposed a build.ui.titleColor option, with the idea that more ui options could be exposed in future. Is this the right location for this option? If so, I'll prepare a PR updating @nuxt/typescript and @nuxt/types.

galvez

I'd call it bannerColor instead of ui.titleColor, since we don't immediately have any other options to place under that key.


        refactor(config, cli): change key to bannerColor


        Merge branch 'add-blue-for-typescript' of github.com:danielroe/nuxt.j…

…s into add-blue-for-typescript

danielroe · 2019-09-27T15:43:21Z

I'd call it bannerColor instead of ui.titleColor, since we don't immediately have any other options to place under that key.

Done!

pi0 · 2019-09-29T09:15:32Z

packages/cli/src/utils/banner.js

@@ -20,7 +20,11 @@ export function showBanner (nuxt, showMemoryUsage = true) {
  const messageLines = []

  // Name and version
-  titleLines.push(`${chalk.green.bold('Nuxt.js')} ${nuxt.constructor.version}`)
+  let bannerColor = 'green'
+  if (nuxt.options.build) {


It is a CLI config why in build namespace? 🤔We have config/cli namespace.

pi0 · 2019-09-29T09:15:32Z

packages/cli/src/utils/banner.js

@@ -20,7 +20,11 @@ export function showBanner (nuxt, showMemoryUsage = true) {
  const messageLines = []

  // Name and version
-  titleLines.push(`${chalk.green.bold('Nuxt.js')} ${nuxt.constructor.version}`)
+  let bannerColor = 'green'


Please keep defaults in config package (test snapshots require update)


        refactor(config, cli): move bannerColor to cli namespace


        fix(cli): destructure properly

pi0

LGTM! Thanks ❤️

kevinmarrec · 2019-09-30T21:32:37Z

@danielroe @pi0 Is there any reason the banner border color hasn't be set to the new option ? :P

kevinmarrec · 2019-09-30T21:33:08Z

Exeteres · 2019-10-01T00:08:27Z

I have the same question 😳

danielroe · 2019-10-01T07:25:52Z

@kevinmarrec @Exeteres I like the idea! (Mind you, in production mode there will be green in the picture too.)

danielroe added 2 commits Sep 11, 2019

feat(cli): display blue 'Nuxt' banner if running with TS

Verified

This commit was signed with a verified signature.

danielroe Daniel Roe

GPG key ID: 37103C9F8C1817F1 Learn about signing commits

Loading status checks…

efc22f3

Closes #6397

fix(cli): remove extra semicolon and test extensions 😳

Verified

This commit was signed with a verified signature.

danielroe Daniel Roe

GPG key ID: 37103C9F8C1817F1 Learn about signing commits

Loading status checks…

a5d55bd

pi0 requested changes Sep 11, 2019

View changes

danielroe added 4 commits Sep 26, 2019

Merge remote-tracking branch 'upstream/dev' into add-blue-for-typescript

Verified

This commit was signed with a verified signature.

danielroe Daniel Roe

GPG key ID: 37103C9F8C1817F1 Learn about signing commits

3a03d3e

feat(cli, config): add ability to customize title color

Verified

This commit was signed with a verified signature.

danielroe Daniel Roe

GPG key ID: 37103C9F8C1817F1 Learn about signing commits

Loading status checks…

8f27e34

test(config): update config snapshots

Verified

This commit was signed with a verified signature.

danielroe Daniel Roe

GPG key ID: 37103C9F8C1817F1 Learn about signing commits

0c5b44d

fix(cli): test presence of build.ui in options

Verified

This commit was signed with a verified signature.

danielroe Daniel Roe

GPG key ID: 37103C9F8C1817F1 Learn about signing commits

Loading status checks…

6ed5b76

danielroe changed the title ~~feat(cli): display blue 'Nuxt' banner if running with TS~~ feat(cli, config): exposes a `build.ui.titleColor` option to change the color of the Nuxt title Sep 26, 2019

Merge branch 'dev' into add-blue-for-typescript

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

7cd326d

danielroe requested a review from pi0 Sep 26, 2019

galvez requested changes Sep 27, 2019

View changes

galvez assigned danielroe Sep 27, 2019

danielroe added 2 commits Sep 27, 2019

refactor(config, cli): change key to bannerColor

Verified

This commit was signed with a verified signature.

danielroe Daniel Roe

GPG key ID: 37103C9F8C1817F1 Learn about signing commits

17d051e

Merge branch 'add-blue-for-typescript' of github.com:danielroe/nuxt.j…

Verified

This commit was signed with a verified signature.

danielroe Daniel Roe

GPG key ID: 37103C9F8C1817F1 Learn about signing commits

Loading status checks…

9208bec

…s into add-blue-for-typescript

danielroe changed the title ~~feat(cli, config): exposes a `build.ui.titleColor` option to change the color of the Nuxt title~~ feat(cli, config): exposes a `build.bannerColor` option to change the color of the Nuxt title Sep 27, 2019

danielroe requested a review from galvez Sep 27, 2019

pi0 requested changes Sep 29, 2019

View changes

danielroe added 2 commits Sep 29, 2019

refactor(config, cli): move bannerColor to cli namespace

Verified

This commit was signed with a verified signature.

danielroe Daniel Roe

GPG key ID: 37103C9F8C1817F1 Learn about signing commits

Loading status checks…

1b43265

fix(cli): destructure properly

Verified

This commit was signed with a verified signature.

danielroe Daniel Roe

GPG key ID: 37103C9F8C1817F1 Learn about signing commits

Loading status checks…

a42432d

pi0 approved these changes Sep 30, 2019

View changes

pi0 changed the title ~~feat(cli, config): exposes a `build.bannerColor` option to change the color of the Nuxt title~~ feat(cli, config): `config.bannerColor` option Sep 30, 2019

pi0 changed the title ~~feat(cli, config): `config.bannerColor` option~~ feat(cli, config): `cli.bannerColor` option Sep 30, 2019

danielroe mentioned this pull request Sep 30, 2019

feat: add custom blue color for nuxt cli #133

Merged

pi0 mentioned this pull request Sep 30, 2019

v2.10.0 #6468

Merged

danielroe deleted the danielroe:add-blue-for-typescript branch Sep 30, 2019

manniL mentioned this pull request Oct 8, 2019

Document cli.bannerColor #1621

Closed

This was referenced Nov 12, 2019

[Snyk] Upgrade nuxt from 2.6.3 to 2.10.2 ajesse11x/webgems#1

Open

[Snyk] Upgrade nuxt from 2.9.1 to 2.10.2 Matthelonianxl/nuxtjs#1

Open

snyk-bot mentioned this pull request Nov 25, 2019

[Snyk] Upgrade nuxt from 1.0.0-rc11 to 2.10.2 #8

Open

nuxt/nuxt.js

feat(cli, config): `cli.bannerColor` option #6399

feat(cli, config): `cli.bannerColor` option #6399

danielroe commented Sep 11, 2019 •

edited

This comment has been minimized.

codecov-io commented Sep 11, 2019 •

edited

pi0 left a comment

This comment has been minimized.

danielroe commented Sep 26, 2019

galvez left a comment •

edited

This comment has been minimized.

danielroe commented Sep 27, 2019

This comment has been minimized.

This comment has been minimized.

pi0 left a comment

This comment has been minimized.

kevinmarrec commented Sep 30, 2019

This comment has been minimized.

kevinmarrec commented Sep 30, 2019

This comment has been minimized.

Exeteres commented Oct 1, 2019

This comment has been minimized.

danielroe commented Oct 1, 2019

Sponsor nuxt/nuxt.js

nuxt/nuxt.js

Join GitHub today

feat(cli, config): `cli.bannerColor` option #6399

Conversation

danielroe commented Sep 11, 2019 • edited

Types of changes

Description

Checklist:

This comment has been minimized.

codecov-io commented Sep 11, 2019 • edited

Codecov Report

pi0 left a comment

This comment has been minimized.

danielroe commented Sep 26, 2019

galvez left a comment • edited

This comment has been minimized.

danielroe commented Sep 27, 2019

This comment has been minimized.

pi0 Sep 29, 2019

This comment has been minimized.

pi0 Sep 29, 2019

pi0 left a comment

This comment has been minimized.

kevinmarrec commented Sep 30, 2019

This comment has been minimized.

kevinmarrec commented Sep 30, 2019

This comment has been minimized.

Exeteres commented Oct 1, 2019

This comment has been minimized.

danielroe commented Oct 1, 2019

danielroe commented Sep 11, 2019 •

edited

codecov-io commented Sep 11, 2019 •

edited

galvez left a comment •

edited