Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): error page layout not correctly applied in client rendering #6479

Merged
merged 5 commits into from Sep 30, 2019

Conversation

@clarkdo
Copy link
Member

clarkdo commented Sep 28, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Description

When error happened in client side rendering (like route change), layout in error.vue is not set.

Fix #2537, fix #5654 and fix nuxt/nuxtjs.org#231

Checklist:

  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.
@clarkdo clarkdo requested a review from nuxt/core-team Sep 28, 2019
clarkdo added 2 commits Sep 28, 2019
@clarkdo clarkdo requested a review from nuxt/core-team Sep 28, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 28, 2019

Codecov Report

Merging #6479 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #6479   +/-   ##
=======================================
  Coverage   95.66%   95.66%           
=======================================
  Files          79       79           
  Lines        2701     2701           
  Branches      697      697           
=======================================
  Hits         2584     2584           
  Misses        101      101           
  Partials       16       16
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.57% <ø> (ø) ⬆️
#unit 92.37% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 950b48f...5c60cd2. Read the comment docs.

@pi0
pi0 approved these changes Sep 29, 2019
@pi0 pi0 requested a review from Atinux Sep 29, 2019
@pimlie pimlie changed the title fix(vue-app): error page layout not correctly applied in client rendeing fix(vue-app): error page layout not correctly applied in client rendering Sep 29, 2019
@pimlie
pimlie approved these changes Sep 29, 2019
@Atinux
Atinux approved these changes Sep 30, 2019
@pi0 pi0 merged commit 578d5d4 into dev Sep 30, 2019
9 checks passed
9 checks passed
Semantic Pull Request ready to be squashed
Details
[ci.azure] nuxt.js #20190930.3 succeeded
Details
ci/circleci: audit Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint-app Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
@pi0 pi0 deleted the fix/error-layout branch Sep 30, 2019
@pi0 pi0 mentioned this pull request Sep 30, 2019
@husayt husayt mentioned this pull request Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.