Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(schema): clean up experimental options #20112

Merged
merged 7 commits into from Apr 7, 2023
Merged

refactor(schema): clean up experimental options #20112

merged 7 commits into from Apr 7, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Apr 6, 2023 •
edited

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

For the upcoming minor release (v3.4), this PR makes three changes to experimental options:

  1. remove experimental.viteNode which has already been deprecated for some time (1b2304b).
  2. remove a completely unused option (viteServerDynamicImports).
  3. move experimental.externalVue to vue.externalLib and deprecate/warn if this option is being used.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 April 6, 2023 13:15
@danielroe danielroe self-assigned this Apr 6, 2023
@codesandbox
Copy link

codesandbox bot commented Apr 6, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe requested a review from Atinux April 7, 2023 08:32
@danielroe danielroe merged commit d4f718d into main Apr 7, 2023
11 checks passed
@danielroe danielroe deleted the fix/experimental-cleanup branch April 7, 2023 10:05
@danielroe danielroe mentioned this pull request Apr 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

@Atinux Atinux Awaiting requested review from Atinux

Assignees

@danielroe danielroe

Labels
3.x chore schema
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielroe @pi0