Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ja): translate guides/features/transitions #619

Merged
merged 4 commits into from
Sep 15, 2020
Merged

docs(ja): translate guides/features/transitions #619

merged 4 commits into from
Sep 15, 2020

Conversation

momokichi
Copy link
Contributor

aytdm
aytdm reviewed Sep 6, 2020
View reviewed changes
Copy link
Contributor

@aytdm aytdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いつもありがとうございます、コメントしました

content/ja/guides/features/transitions.md Outdated Show resolved Hide resolved
content/ja/guides/features/transitions.md Show resolved Hide resolved
content/ja/guides/features/transitions.md Show resolved Hide resolved
content/ja/guides/features/transitions.md Outdated Show resolved Hide resolved
content/ja/guides/features/transitions.md Outdated Show resolved Hide resolved
content/ja/guides/features/transitions.md Outdated Show resolved Hide resolved
content/ja/guides/features/transitions.md Outdated Show resolved Hide resolved
content/ja/guides/features/transitions.md Outdated Show resolved Hide resolved
@momokichi
Copy link
Contributor Author

ていねいなレビューをいつもありがとうございます。
0c0d596 にて修正したので確認お願いします。

aytdm
aytdm approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@aytdm aytdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご対応ありがとうございます！こちらこそいつも丁寧なPR＆迅速な対応をありがとうございます
ライブプレビューの方のレビューが遅れていてすみません、今週中には返すのでもう少しお待ちください:pray:

@aytdm
Copy link
Contributor

aytdm commented Sep 7, 2020

@debs-obrien Hi, I would like you to merge this PR. Thanks :)

This was referenced Sep 13, 2020
Closed
Merged
@aytdm
Copy link
Contributor

aytdm commented Sep 15, 2020

@debs-obrien Could you please merge this PR as well? I'm sorry if I am being impolite or too straightforward.

@debs-obrien
Copy link
Contributor

@aytdm this is perfect. I will merge all pr's that you tag me in for japanese. If you don't tag me then I will presume they are not ready so please feel free to tag me whenever. Thanks 😃

@debs-obrien debs-obrien merged commit 5934526 into nuxt:master Sep 15, 2020
@momokichi momokichi deleted the ja/guides/features/transitions branch September 15, 2020 23:23
@aytdm aytdm mentioned this pull request Oct 6, 2020
Merged
@aytdm aytdm mentioned this pull request Oct 25, 2020
Closed
93 tasks
@aytdm aytdm added the japanese label Oct 25, 2020
pi0 pushed a commit that referenced this pull request Jul 8, 2021
@momokichi
docs(ja): translate guides/features/transitions (#619)
11f47bb 
* add: transitions.md

* translate: description

* fix

* update: reflect reviews
imgbot bot pushed a commit that referenced this pull request Jan 10, 2023
@momokichi @ImgBotApp
docs(ja): translate guides/features/transitions (#619)
b98e2c6 
* add: transitions.md

* translate: description

* fix

* update: reflect reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aytdm aytdm aytdm approved these changes

Assignees
No one assigned
Labels
japanese
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@momokichi @aytdm @debs-obrien