Skip to content
Permalink
Browse files

Update miscDeps to include new dump_syms which works with VS 2019.

  • Loading branch information
michaelDCurran committed Feb 17, 2020
1 parent 141361b commit 2583bc64247d643a4fd26098b165a9edf32290dc
Showing with 3 additions and 9 deletions.
  1. +1 −7 appveyor.yml
  2. +1 −1 appveyor/mozillaSyms.py
  3. +1 −1 miscDeps
@@ -249,14 +249,8 @@ deploy_script:
}
ConvertTo-Json -InputObject $data -Compress | ssh nvaccess@exbi.nvaccess.org nvdaAppveyorHook
# Upload symbols to Mozilla.
Start-FileDownload https://github.com/mozilla/gecko-dev/raw/12c357c/toolkit/crashreporter/tools/win32/dump_syms_vc1800.exe -FileName appveyor\dump_syms.exe
py -m pip install --no-warn-script-location requests
# dump_syms needs to locate msdia140.dll which in the vs 2019 appveyor image is no longer in the path it seems.
# dump_syms was producing the error: CoCreateInstance CLSID_DiaSource {E6756135-1E65-4D17-8576-610761398C3C} failed (msdia*.dll unregistered?)
# Add its directory to path as recommended by https://groups.google.com/a/chromium.org/forum/#!topic/crashpad-dev/0xUdfp8_LqA
# regsvr32 /s "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\IDE\Remote Debugger\x86\msdia140.dll"
# $env:PATH = "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\IDE\Remote Debugger\x86;$env:PATH"
# py appveyor\mozillaSyms.py
py appveyor\mozillaSyms.py
}
on_finish:
@@ -14,7 +14,7 @@
import requests

SCRIPT_DIR = os.path.abspath(os.path.dirname(__file__))
DUMP_SYMS = os.path.join(SCRIPT_DIR, "dump_syms.exe")
DUMP_SYMS = os.path.join(os.path.dirname(SCRIPT_DIR), "miscDeps", "tools, "dump_syms.exe")
NVDA_SOURCE = os.path.join(os.path.dirname(SCRIPT_DIR), "source")
NVDA_LIB = os.path.join(NVDA_SOURCE, "lib")
NVDA_LIB64 = os.path.join(NVDA_SOURCE, "lib64")

0 comments on commit 2583bc6

Please sign in to comment.
You can’t perform that action at this time.