From 91159a2c638416a47881b436f0f002e48204bc91 Mon Sep 17 00:00:00 2001 From: Reef Turner Date: Thu, 27 Oct 2016 10:59:41 +0800 Subject: [PATCH] No longer set the language before restarting (PR #6415) Fixes #4561 When a new language is selected (on the general settings dialog) and the ok button is pushed, the language is not changed until until NVDA is restarted. This fixes an issue where some parts of the UI are translated and some are not. --- source/gui/settingsDialogs.py | 7 ------- 1 file changed, 7 deletions(-) diff --git a/source/gui/settingsDialogs.py b/source/gui/settingsDialogs.py index 87fc44702c6..fa4c0243959 100644 --- a/source/gui/settingsDialogs.py +++ b/source/gui/settingsDialogs.py @@ -257,13 +257,6 @@ def onCopySettings(self,evt): def onOk(self,evt): newLanguage=[x[0] for x in self.languageNames][self.languageList.GetSelection()] - if newLanguage!=self.oldLanguage: - try: - languageHandler.setLanguage(newLanguage) - except: - log.error("languageHandler.setLanguage", exc_info=True) - gui.messageBox(_("Error in %s language file")%newLanguage,_("Language Error"),wx.OK|wx.ICON_WARNING,self) - return config.conf["general"]["language"]=newLanguage config.conf["general"]["saveConfigurationOnExit"]=self.saveOnExitCheckBox.IsChecked() config.conf["general"]["askToExit"]=self.askToExitCheckBox.IsChecked()