NVDA no longer fails to install if the user's profile path contains c…

…ertain multibyte characters. Another fix for #2729. Instead of monkeypatching Python's tempfile module only in nvda.pyw, moe this code in to a new pythonMonkeyPatches module and import it (apply them) from both nvda.pyw and nvda_slave.pyw.

source/nvda.pyw

@@ -6,16 +6,9 @@
 
 """The NVDA launcher. It can handle some command-line arguments (including help). It sets up logging, and then starts the core."""
 
-import ctypes
-
-# #2729: Python's tempfile.get_default_tempdir() has a bug when handling multibyte paths. os.path.normcase is used incorrectly.
-# Override this to use the temp path as returned by Windows.
-import tempfile
-tempPath = ctypes.create_string_buffer(260)
-if ctypes.windll.kernel32.GetTempPathA(260, tempPath) > 0:
-	# Strip trailing backslash which is always included.
-	tempfile.tempdir = tempPath.value[:-1]
+import pythonMonkeyPatches
 
+import ctypes
 import os
 import sys
 import locale

source/nvda_slave.pyw

@@ -2,6 +2,8 @@
 Performs miscellaneous tasks which need to be performed in a separate process.
 """
 
+import pythonMonkeyPatches
+
 import sys
 import os
 import logHandler

source/pythonMonkeyPatches.py

@@ -0,0 +1,15 @@
+#A part of NonVisual Desktop Access (NVDA)
+#Copyright (C) 2006-2013 NVDA Contributors <http://www.nvda-project.org/>
+#This file is covered by the GNU General Public License.
+#See the file COPYING for more details.
+
+"""Fixes some broken features in Python such as gettempdir"""
+
+# #2729: Python's tempfile.get_default_tempdir() has a bug when handling multibyte paths. os.path.normcase is used incorrectly.
+# Override this to use the temp path as returned by Windows.
+import ctypes
+import tempfile
+tempPath = ctypes.create_string_buffer(260)
+if ctypes.windll.kernel32.GetTempPathA(260, tempPath) > 0:
+	# Strip trailing backslash which is always included.
+	tempfile.tempdir = tempPath.value[:-1]

user_docs/en/changes.t2t

@@ -47,6 +47,7 @@
 - Text selection is now correctly shown on a braille display in applications such as Microsoft word 2003 and Internet Explorer edit controls.
 - It is again possible to select text in a backward direction in Microsoft Word while Braille is enabled.
 - When reviewing,  backspacing or deleting characters  In Scintilla edit controls, NVDA correctly announces multibyte characters. (#2855)
+- NVDA will no longer fail to install when the user's profile path contains certain multibyte characters. (#2729)
 
 
 == Changes for Developers ==