Permalink
Tree: 9509c256f2
Commits on Feb 11, 2019
  1. Fix spelling mistake in default issue template.

    feerrenrut committed Feb 11, 2019
  2. Ensure some issue template is always shown

    feerrenrut committed Feb 11, 2019
    When visiting GitHub via the `nvda/issues/new` URL no template is presented, now the bug report template is shown by default. There is a message at the beginning that explains that the `nvda/issues/new/choose` URL should be used instead. There is also URLs to jump directly to the creation of bug reports and feature requests. 
    The header is not included in the HTML comment, this allows the the links to become clickable by swapping to the preview page. It will also make it easier for us to tell when someone has used this template (if they do not delete this header).
  3. Provide configurable developer scratchpad dir rather than automatic l…

    michaelDCurran committed Feb 11, 2019
    …oading of custom code (#9238)
    
    * NVDA no longer automatically loads custom code from package directories in the NVDA user configuration directory. Rather it will load tem from subdirectories in a new 'scratchpad' directory in the NVDA user configuration directory, but only if the open in the advanced category is enabled.
    
    * System tests use Developer scratchpad directory for the Robot globalPlugin.
    
    * Don't load from the developer scratchpad dir if NVDA is running in secure mode.
    
    * Update more system test paths to scratchpad.
    
    * Remove spaces at start of line.
    
    * Update what's new.
  4. Speed ups to ms word object model (#9217)

    michaelDCurran committed Feb 11, 2019
    * winword support in nvdaHelper: speed things up a bit by optimizing for only one layout column, remove some debugging code, and turn off screenUpdating while collecting text formatting.
    
    * Winword support in nvdaHelper: fetch editor revision information much more efficiently, similarly to how we fetch comments and spelling errors.
    
    * MS Word object model support: rather than disabling screen updating specifically from within each in-process call, disable it from Python the first time it is required in a core cycle, re-enabling it at the end of the core cycle.
    
    * speech.speakTextInfo: if the unit is paragraph, cell or story, don't fetch costly formatting info such as spelling errors and editor revisions, even if the user has these turned on.
    
    * NVDAHelper MS Word support: add more debug warning log statements.
    
    * Revert "speech.speakTextInfo: if the unit is paragraph, cell or story, don't fetch costly formatting info such as spelling errors and editor revisions, even if the user has these turned on."
    
    This reverts commit 6ea9d0f.
    
    * When navigating by table cell in MS Word, only speak the first line of the next cell, otherwise it may take a very long time to collect all content for the cell.
    
    * When navigating by paragraph, spelling errors and editor revisions will not be announced. It is important that navigating by paragraph is performant as it is used for quick skimming.
    
    * MS Word: Optimize collapse so that end is only fetched if needed.
    
    * Navigating by table cell in MS Word again speaks the entire cell, but editor revisions and spelling errors (like when navigating by paragraph) are no longer spoken for navigating by table cell.
    
    * Only disable spelling errors when speaking paragraphs and table cells. Editor revisions are okay.
    
    * MS Word nvdaHelper support: remove unneeded fetching of application object.
    
    * MS Word support: remove old comment.
    
    * MS Word support: go back to disabling screen updating in-process for now, but do it from a RAAI class so that it can be re-enabled automatically at the end of scope.
    
    * Address review comments.
    
    * Update what's new.
Commits on Feb 8, 2019
  1. restore prompt for restart after installing an addon from shell (PR #…

    feerrenrut committed Feb 8, 2019
    …9251)
    
    Fixes #9226
    
    * restore prompt for restart after installing an addon from shell
    * fix typo in incompatible addon message
    * add an accelerator to the close button in incompat addons dialog
  2. Added support for Connect Braille and Basic Braille 84. (#9249)

    FelixGruetzmacher authored and michaelDCurran committed Feb 8, 2019
    * Added support for Connect Braille and Basic Braille 84.
    
    * Update what's new.
Commits on Feb 5, 2019
  1. Stop the Virtualbox>=5.2 main window from freezing (#9211)

    leonardder authored and michaelDCurran committed Feb 5, 2019
    * Improve qt container child fetching
    
    * Update what's new.
Commits on Feb 4, 2019
  1. Fix wrong brackets in DisplayModelTextInfo.boundingRects property (#9237

    leonardder authored and michaelDCurran committed Feb 4, 2019
    )
Commits on Feb 1, 2019
  1. Fix possible freeze related to custom checklistboxes (PR #9224)

    leonardder authored and feerrenrut committed Feb 1, 2019
    * Fix possible freeze related to custom checklistboxes
    
    `gui.nvdaControls.CustomCheckListBox` uses a custom `AccPropServer` for accessibility. However, when destroying the control, the `AccPropServer` wasn't properly unregistered. This leads to unexpected behavior, sometimes even to system freezes.
    
    While this was fixed for `AutoWidthColumnCheckListCtrl` it was not for `CustomListBox`. Now the AccPropServer instance itself is responsible for registration and unregistration. This cleanup is triggered by binding to the the control's window destroyed wx event.
Commits on Jan 31, 2019
  1. New addon api versioning approach (PR #9151)

    feerrenrut committed Jan 31, 2019
    Closes #9055
    
    * The incompatible addons dialog is no longer shown on startup. Since there is no saved state, this would warn about any installed incompatible addons every time NVDA was started.
    * Replace compatibility checks
       - NVDA now uses two (internal) values to determine addon compatibility, in addition to the `lastTestedNVDAVersion` and `minimumNVDAVersion` from the addonManifest. These new values are `CURRENT` and `BACK_COMPAT_TO`, in the addonAPIVersion module.
      - An addon is considered compatible if there is an overlap of the two ranges formed by the addon manifest values and the internal NVDA values.
      - Renamed `_showAddonUntestedDialog`
        - Clarified the name of the function to report that an addon is no longer supported by NVDA. The addon is considered "too old". As opposed to NVDA being "too old" for a newly developed addon.
    * Introduce a new method of stopping incompatible addons from "running".
      - No longer "disable" them to stop them from running.
      - When being set to disabled, the state was being saved. This meant the launcher could interfere with an installed version of NVDA, even if the installation was aborted.
      - We rely on `_getAvailableAddonsFromPath` to be setting the blocked state.
      - Improve comment in `addToPackagePath`, which is currently the end point for "enabling" an addon.
    * Addon API version values are now used as tuples throughout code.
      - Read from addon manifest and validate and convert to tuple.
      - Validate manifest condition: `minRequiredVersion <= lastTested`
        - It's not sensible to have a minRequiredVersion later than the version
    tested against.
    * Update info for NVDA now keeps `APIVersion` and `backCompatibleToVersion` as tuples rather than strings.
      - When an update is postponed it is saved as a tuple.
      - This saves confusion about whether its a string or a tuple.
    * Fix freeze on exit when destroy not called manually for `AutoWidthColumnCheckListCtrl`
       - Removes need to manually call destroy on `IncompatibleAddonsDialog`
       - `accPropServices` needs to be cleaned up when the control is destroyed. The `Destroy` method is not called by the wx framework, but we can register to receive the event see wxWidgets/Phoenix#630
    * Allow the possibility of using a parent window other than the addon manager when installing an addon. Useful in the case of installing via a shell extension, where gui.mainframe should be the parent.
      - Removed coupling between the `installAddon` function and `AddonManager` class
      - Reduced nesting of the `installAddon` function
      - Moved methods to module level. These had no dependence on instance, or class level members.
    * Use windows sounds for addon install warning / error dialogs.
    * Use context manager for writing to file in `_download` of class `UpdateDownloader` in `updateCheck.py`
      - There were several ways that the file could fail to be closed.
    * Unified the way that NVDA versions / API versions are formatted to a string, added tests
      - One function is for outputting a full version string (including build part).
      - The other is for formatting a version string for the GUI (which will remove the minor part when it is zero).
    * Moved the regex used to convert addon manifest API versions from strings to tuples into the `addonAPIVersion` module.
    * No longer raise error for failed audio ducking when it failed due to "access denied"
      - Ensure that a warning is put in the log for access denied errors when setting audio ducking.
  2. MMC app module (#9118)

    codeofdusk authored and michaelDCurran committed Jan 31, 2019
    * Fixed #1486.
    
    This commit fixes #1486 by adding a custom app module for the Microsoft Management Console.
    
    * Review actions.
    
    * Review items.
    
    * New implementation based on focus redirect and gainFocus events
    
    * Use an overlay for table cells
    
    * Style.
    
    * Style.
    
    * Cosmetics
    
    * Update what's new.
  3. Emoji panel: emoji search results, automation ID based event handler,…

    josephsl authored and michaelDCurran committed Jan 31, 2019
    … catch attribute error exception when closing the panel (#9112)
    
    * Modern keyboard: update app module description text to include cloud clipboard paste functionality.
    
    * Composable Shell/window open event: use automation ID's to look up which input panel technology should be handled. Re #9104.
    
    Previously NVDA assumed that emoji panel is the only thing to be handled, thus looked up build number and child count. However, it was later discovered that different input panel features expose different automation ID's for various features. Thus use this (along with build number if appropriate) when dealing with different aspects of modern input panel.
    
    * Composable Shell/various events: catch attribute error for several parents and objects, especially when closing emoji panel. Re #9106.
    
    * Composable Shell/emoji panel: handle sking tone modifiers.
    
    In Windows 10 Version 1809 and later, people emoji includes skin tone modifiers. Thus detect this and move to the appropriate emoji when searching for people emoji.
    
    * Composable Shell/emoji panel: announce top emoji when searching for one. Re #9105.
    
    While searching for emojis in Version 1809 and later, name change event is fired by search block text. However, item selection event is also fired, which means only the results count will be announced, not the moji itself. Thus return from name change event if emoji search is under way.
    
    * Update what's new.
  4. What's new: fix typo in an entry.

    michaelDCurran committed Jan 31, 2019
  5. What's new: remove entry from bug fixes mentioning MS Word performanc…

    michaelDCurran committed Jan 31, 2019
    …e improvements due to UIA support. This was disabled by default in #9200.
  6. Make UIA in MS Word optional again, through an Advanced Settings cate…

    michaelDCurran committed Jan 31, 2019
    …gory (#9200)
    
    * _UIAHandler: don't use UIA in MS Word by default as it is still not ready. Rather, still allow it to be used byased on the useInMSwordWhenAvailable config option.
    
    * Add an Advanced settings category to NVDA's Settings dialog.  This contains all config options that were previously not accessible from the GUI. this includes:
    Use UIA in MS Word, caret movement timeout, and the debug log categories.
    
    * Address review comments. Debug log categories are now a checkListBox, and fixed typo in userGuide.
    
    * Fix typos in userGuide.
    
    * Update what's new.
  7. In-process components on ARM64 (#9216)

    jcsteh authored and michaelDCurran committed Jan 31, 2019
    * Upgrade SCons to version 3.0.4.
    
    This required some tweaks to the sconscripts for ISimpleDOM and MathPlayer.
    We copy the idl file into the build directory ourselves, but it depends on other files.
    It seems SCons no longer scans for dependencies in files we copy ourselves.
    Thus, we must explicitly declare those dependencies.
    
    * Build and install in-process components for ARM64.
    
    These are placed in a new libArm64 directory (alongside lib and lib64).
    MinHook doesn't support ARM64, so disable MinHook and everything that depends on it (notably displayModel).
    
    * Start nvdaHelperRemoteLoader appropriately on ARM64.
    
    * Fix AppModule.is64BitProcess for ARM64.
    
    Previously, it always returned True, even for 32 bit processes.
    On ARM64, isWow64Process always returns False.
    We must instead use IsWow64Process2 where supported.
    
    * Update readme to list the additional Visual Studio components we now require.
    
    * Update what's new.
Commits on Jan 29, 2019
  1. renamed Norwegian braille table to a new one as requested and adds af…

    zstanecic authored and michaelDCurran committed Jan 29, 2019
    …rikaans table (#9186)
    
    * added czech eight dots computer table
    
    * added hungarrian braille table
    
    * update braille tables file
    
    * review actions
    
    * review actions,
    note, if the unit tests pass, this can be merged into master
    
    * review action, change k to K in Central Kurdish
    
    * added norwegian new 8-dots braille table, added Afrikaans table present before
    
    * updated copiright headers,
    fixed dictionary declarations for the norwegian table
    
    * Update source/brailleTables.py
    
    covering new braille table rename.
    
    Co-Authored-By: zstanecic <zvonimirek222@yandex.com>
    
    * oops, we don't have no-no.ctb table, and it errored with heck.
    
    * Revert "oops, we don't have no-no.ctb table, and it errored with heck."
    
    This reverts commit 2da5d52.
    
    * Update what's new.
  2. Work around frozen keyboard input while the NVDA core is frozen (#9208)

    leonardder authored and michaelDCurran committed Jan 29, 2019
    * Try to work around frozen keyboard input while the NVDA core is frozen
    
    * Update what's new.
Commits on Jan 24, 2019
  1. Ensure browse mode is used when reading Outlook messages with UI auto…

    michaelDCurran committed Jan 24, 2019
    …mation enabled (#9188)
    
    * When UIA is used to access messages in Outlook, ensure that browseMode is turned on by default when reading messages.
    Also handle the case where Outlook causes UIA to return mixedAttributes when searching for headings.
    
    * Update comments.
    
    * Update what's new.
  2. Announce context menus in Outlook 2016 and existance of submenus (#9189)

    michaelDCurran committed Jan 24, 2019
    * Don't suppress collapsed / expanded states on menu items if the menu item does not have the hasPopup state, as these states could be denoting it is a sub menu.
    
    * Handle special placeholder menu items in NetUI (such as MS Office context menus) when the menu appears but nothing real is focused. Bounce focus up to the menu itself for better presentation.
Commits on Jan 23, 2019
  1. Gecko vbuf: Render the selected item in list boxes and trees. (#9166)

    jcsteh authored and michaelDCurran committed Jan 23, 2019
    * Gecko vbuf: Render the selected item in list boxes and trees.
    
    If there is no selected item, render the first child.
    This allows the user to see the selected item without having to switch to focus mode.
    It also allows focus to move into list boxes and trees where the container itself isn't focusable but the selected item is, as permitted by the ARIA spec.
    
    This required changing speech.getControlFieldSpeech so that the content of lists and trees is spoken after the control field info for REASON_FOCUS.
    Otherwise, moving to a list box or tree with quick navigation would speak the selected item first.
    List item also had to be added to the roles which always enable pass through, as this change means that a list item can now be under the cursor when enter is pressed. (Read only list items are still excluded by an earlier check.)
    
    This is currently disabled for HTML select size>1 controls in Chrome.
    These list items get the focusable state but setting focus programmatically does nothing.
    Therefore, we don't want to render these in Chrome because a user wouldn't be able to focus these list boxes in browse mode if we did.
    
    * Update what's new.
  2. Fix table navigation in threaded view in Mozilla Thunderbird (#9185)

    mltony authored and michaelDCurran committed Jan 23, 2019
    * Fix table navigation in threaded view in Mozilla Thunderbird
    
    * Update what's new.
  3. Ensure that spelling errors, gramma errors, and other annotations are…

    michaelDCurran committed Jan 23, 2019
    … still reported in UI Automation documents when IUIAutomationTextRange3 is not available. (#9180)
Commits on Jan 21, 2019
  1. Fix functionality of the last 16 routing keys on 80 cell eurobraille …

    leonardder authored and michaelDCurran committed Jan 21, 2019
    …displays (#9160)
    
    * Fix functionality of the last 16 routing keys on a 80 cell eurobraille display
    
    * Update what's new.
  2. Optional logging of time since input when speaking. (#9167)

    jcsteh authored and michaelDCurran committed Jan 21, 2019
    * Optional logging of time since input when speaking.
    
    This allows for easy measurement of perceived responsiveness.
    It can be enabled in the debugLog section of the config using the timeSinceInput setting.
    It is logged at level IO if this setting is enabled.
    
    * Move the time to the start of the log message to make it faster to read.
    
    * Update what's new.
Commits on Jan 15, 2019
  1. Uia in ms word by default (#8919)

    michaelDCurran committed Jan 15, 2019
    * UIAHandler: Use UIA in MS Word documents by default for MS Office for  version 16.0.9000 and above.
    
    * Stop refusing to use UIA for MS Office Ribbons, rather fix  specific problems directly: Office 2010 options dialog comboboxes have no name, and Outlook pre 2016 autoComplete list should use MSAA.
    
    * UIA WordDocumentTextInfo: remove custom implementation of isCollapsed property. It is no longer needed in recent versions of MS Word, and in fact it was causing tables to not be reported when positioned on a blank cell.
    
    * UIATextInfo.UIAElementAtStart: catch a COMError when fetching children. Seen at the bottom of MS Word documents.
    
    * Address review actions.
    
    * Fix typo in _UIAHandler: MS Office build number should be 9000 not 90000.
    
    * Work around bug in MS Word where a table cell could appear outside of a table in the UIA tree, causing a 10 second freeze and infinite recursion error.
    
    * Update what's new.
Commits on Jan 14, 2019
  1. Check, that SCons is started with Python 2.7 32-bit and warn the user…

    lukaszgo1 authored and michaelDCurran committed Jan 14, 2019
    … if not. (#8926)
    
    * Ensure, that SCons is started with Python 2.7 32-bit fail otherwise. Fix for #7095
    
    * Improve readability of the displayed message.
    
    * Review actions
    
    * Review actions.
  2. ia2utils HyperlinkGetter: Switch to CComPtr (#9152)

    jcsteh authored and michaelDCurran committed Jan 14, 2019
    * ia2utils HyperlinkGetter: Switch to CComPtr (instead of _com_ptr_t) so C++ exceptions don't get thrown for COM errors.
    
    Newer code uses CComPtr already, so it made sense to switch rather than catching the exceptions.
    
    * Update what's new.
  3. Fix regression when reading and deleting text in MS Excel edit fields. (

    lukaszgo1 authored and michaelDCurran committed Jan 14, 2019
    #9063)
    
    * Make cursor tracking and announcement of deleted characters working again in Microsoft Excel edit fields. Fix for #9042
    
    * Revert "Make cursor tracking and announcement of deleted characters working again in Microsoft Excel edit fields. Fix for #9042"
    
    This reverts commit c360ddf.
    
    * Add app module for Excel. This simply uses displayModel for edit fields.
    
    * Review actions.
    
    * Update What's new.
  4. Merge branch 'beta'

    michaelDCurran committed Jan 14, 2019
  5. Merge branch 'rc' into beta

    michaelDCurran committed Jan 14, 2019
Commits on Jan 10, 2019
  1. Update translations.

    NVDA translation automation
    NVDA translation automation committed Jan 10, 2019
    From translation svn revision: 46598
  2. L10n updates for: zh_TW

    NVDA translation automation
    NVDA translation automation committed Jan 10, 2019
    From translation svn revision: 46598
    
    Authors:
    wangjanli@gmail.com
    maro.zhang@gmail.com
    Aaron Wu <waaron2000@gmail.com>
    Victor Cai <surfer0627@gmail.com>
    
    Stats:
    32	19	source/locale/zh_TW/characterDescriptions.dic
     1 file changed, 32 insertions(+), 19 deletions(-)
  3. L10n updates for: zh_CN

    NVDA translation automation
    NVDA translation automation committed Jan 10, 2019
    From translation svn revision: 46598
    
    Authors:
    vgjh2005@gmail.com
    jiangtiandao901647@gmail.com
    manchen0528@gmail.com
    sysking1024@gmail.com
    dingpengyu06@gmail.com
    
    Stats:
    2	2	source/locale/zh_CN/LC_MESSAGES/nvda.po
    54	65	source/locale/zh_CN/characterDescriptions.dic
     2 files changed, 56 insertions(+), 67 deletions(-)
  4. L10n updates for: so

    NVDA translation automation
    NVDA translation automation committed Jan 10, 2019
    From translation svn revision: 46598
    
    Authors:
    Othmanothman <othman82@hotmail.com>
    
    Stats:
    17	7	source/locale/so/LC_MESSAGES/nvda.po
     1 file changed, 17 insertions(+), 7 deletions(-)