Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 10/Windows Search: add support for File Explorer embedded search experience in Version 1909 and later #10341

Closed
josephsl opened this issue Oct 6, 2019 · 2 comments · Fixed by #10349
Milestone

Comments

@josephsl
Copy link
Collaborator

josephsl commented Oct 6, 2019

Hi,

Another one in a series of issues on Windows 10/Windows Search:

Background:

Windows 10 Version 1909 (likely to be called October 2019 Update) and later includes online search capability in File Explorer. This feature, powered by redesigned Windows Search, is used to allow users to search OneDrive content. As the search progresses, a live region informs result count. Because of the way search box is handled, braille will initially display "suggestions" instead of displaying this live region.

Is your feature request related to a problem? Please describe.

As noted above, a live region text is used to announce results count. Unfortunately this region isn't labeled, and the text itself is the first child of this region, necessitating NVDA descending one level to announce this live region.

Also, when using braille, the word "suggestions" is brailed before the live region is displayed. This is caused by search box recognition code in SearchUI app module where Start menu search field is recognized as a pure UIA search field. Thus suggestionsOpened event must be modified in sTart menu search field to not braille suggestions message (a separate issue but is grouped under this one to provide context).

Describe the solution you'd like

Add support for Version 1909 File Explorer/Windows Search facility by:

  1. For the live region: give it the name of the child object so live region change event can function properly.
  2. Add a custom version of suggestionsOpened event for Start menu search field so braille won't have to say "suggestions".
  3. Optionally, rename searchui.StartMenuSearchField to something else (later).

Describe alternatives you've considered

Leave it as is.

Additional context

The fix described above is part of Windows 10 App Essentials add-on and is being tested. Also, it would be ideal to see this feature implemented by 2019.3 or shortly after. Also, in 20H1, Windows Search executable has been renamed to SearchApp.exe, so we need to take care of that by 2020.1 release.

Thanks.

josephsl added a commit to josephsl/nvda that referenced this issue Oct 8, 2019
…indows 10 Version 1909. Re nvaccess#10341.

In Windows 10 Version 1909 (build 18363) and later, File Explorer gains ability to search OneDrive content. This is powered by an embedded Windows Search feature (SearchUI.exe) with a live region announcing suggestion count. This live region has no label, but the child object does, thus coerce the name of this object to be the name of its child, which then allows live region change event to work.
josephsl added a commit to josephsl/nvda that referenced this issue Feb 16, 2020
…indows 10 Version 1909. Re nvaccess#10341.

In Windows 10 Version 1909 (build 18363) and later, File Explorer gains ability to search OneDrive content. This is powered by an embedded Windows Search feature (SearchUI.exe) with a live region announcing suggestion count. This live region has no label, but the child object does, thus coerce the name of this object to be the name of its child, which then allows live region change event to work.
josephsl added a commit to josephsl/nvda that referenced this issue May 20, 2021
…ble from Windows 10 Version 1909 (build 18363/NOvember 2019 Update). Re nvaccess#10341.

Comment from Reef Turner (NV Access): clarify that Windows Search/suggestion count in File Explorer is available from Windows 10 Version 1909, also split the condition into multiple lines to prepare for Flake8 (lint).
@feerrenrut

This comment has been minimized.

@feerrenrut

This comment has been minimized.

feerrenrut pushed a commit that referenced this issue Jul 8, 2021
…ion 1909 and later (PR #10349)

Fixes #10341

# Summary of the issue:
In Windows 10 Version 1909, File Explorer gains ability to search OneDrive content via Windows Search, with a live region used to provide suggestion count announcement.

# Description of changes:
In Windows 10 Version 1909 (build 18363) and later, File Explorer gains ability to search OneDrive content. This is powered by an embedded Windows Search feature (SearchUI.exe) with a live region announcing suggestion count. This live region has no label, but the child object does, thus coerce the name of this object to be the name of its child, which then allows live region change event to work.
@nvaccessAuto nvaccessAuto added this to the 2021.2 milestone Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants