-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In general settings panel, language combo-box is not sorted correctly #10348
Comments
CyrilleB79 wrote:
* In English or other Windows UI languages, is the issue also present?
Not in English.
|
Also not in portuguese. |
In Dutch, it's also fine here. |
Hi, That's not the case for German
Am 07.10.2019 um 23:12 schrieb CyrilleB79:
…
Steps to reproduce:
* Open General property settings page, e.g. pressing NVDA+Ctrl+G
* Open language combo-box and look at the order of the language list
Actual behavior:
The list is sorted as follow :
* Afrikaans (Afrique du Sud), af_ZA
* [most of all languages]
* Vietnamien, vi
* macédonien, mk
* norvégien, bokmål (Norvège), nb_NO
* norvégien, nynorsk (Norvège), nn_NO
* User default
Expected behavior:
The list is sorted as follow :
* Afrikaans (Afrique du Sud), af_ZA
* [all languages]
* Vietnamien, vi
* User default
Analysis
* The names of the languages are provided by Windows itself ; that's
why it is in French here, whatever the language of NVDA.
* Seems that Windows provides 3 language names starting with lower
case and the others with upper case.
* A solution would be to sort language names without taking into
account case.
* In English or other Windows UI languages, is the issue also present?
System configuration
NVDA installed/portable/running from source:
Installed or portable or source
NVDA version:
2019.2.1 and 2019.3
Windows version:
Windows 10 1903 and Windows 10 1709, both French UI.
Name and version of other software in use when reproducing the
issue:
N/A
Other information about your system:
Other questions
Does the issue still occur after restarting your PC?
Yes
Have you tried any other versions of NVDA? If so, please
report their behaviors.
Already present on some earlier versions of NVDA.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#10348?email_source=notifications&email_token=ACV2PZOPRWQXQA7NIMFOFELQNOQ25A5CNFSM4I6J3OD2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HQFYGRQ>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACV2PZLJJ3A7ILNGQE5BCXTQNOQ25ANCNFSM4I6J3ODQ>.
|
After investigations on French Windows 10 1709 and 1903, I confirm the following fact. GetLocaleInfoW in kernel32.dll called with LOCALE_SLANGDISPLAYNAME or LOCALE_SLANGUAGE returns:
The sorting issue does not appear in NVDA on Windows 7 and all languages in the list begin with upper case. Moreover by trying to fix this issue, I have seen that there are other sorting issue in this list. In today's 2019.2.1 and in today's alpha, the orderr on French Windows is as follow:
...
|
Fixes #10348 The language list in general settings panel was not ordered correctly in French due to 2 issues: - Some localized languages names returned by Windows start with lower case whereas the vast majority of the language names start with upper case. - "é" does not appear at the position of "e" when sorting but after all letters without accent marks. e.g. "Géorgien" incorrectly appears after "Grec". Co-authored-by: Leonard de Ruijter <leonardder@users.noreply.github.com> Co-authored-by: Reef Turner <feerrenrut@users.noreply.github.com>
Steps to reproduce:
Actual behavior:
The list is sorted as follow :
Expected behavior:
The list is sorted as follow :
Analysis
System configuration
NVDA installed/portable/running from source:
Installed or portable or source
NVDA version:
2019.2.1 and 2019.3
Windows version:
Windows 10 1903 and Windows 10 1709, both French UI.
Name and version of other software in use when reproducing the issue:
N/A
Other information about your system:
Other questions
Does the issue still occur after restarting your PC?
Yes
Have you tried any other versions of NVDA? If so, please report their behaviors.
Already present on some earlier versions of NVDA.
The text was updated successfully, but these errors were encountered: