Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVDA cannot upgrade old settings if winConsoleSpeakPasswords is present. #10598

Closed
davidacm opened this issue Dec 9, 2019 · 1 comment
Closed
Milestone

Comments

@davidacm
Copy link
Contributor

@davidacm davidacm commented Dec 9, 2019

Steps to reproduce:

  1. Enable "Speak &passwords in Windows Console (may improve performance)" in advanced settings.
  2. Try to install NVDA 2019.3beta1.

Actual behavior:

An exception is generated and the current config is not updated. All current user settings are lost.

ERROR - config.ConfigManager.initBaseConf (05:37:42.736) - MainThread (12356):
Error loading base configuration
Traceback (most recent call last):
File "config_init
.pyc", line 424, in initBaseConf
File "config_init
.pyc", line 458, in loadConfig
File "config_init
.pyc", line 454, in _loadConfig
File "config\profileUpgrader.pyc", line 24, in upgrade
File "config\profileUpgrader.pyc", line 41, in doConfigUpgrade
File "config\profileUpgradeSteps.pyc", line 60, in upgradeConfigFrom_2_to_3
File "configobj_init
.pyc", line 502, in getitem
KeyError: 'terminals'
INFO - config.ConfigManager._loadConfig (05:37:42.736) - MainThread (12356):
Loading config: None

The solution is quite simple and important to solve for users when upgrade to newer NVDA's versions.
Just check if the key "terminals" exists and create it if needed in the upgradeConfigFrom_2_to_3 function.

Expected behavior:

The current user settings are updated without losing them.

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

2019.2.1 and 2019.3beta1

Windows version:

Windows 10 1903

Name and version of other software in use when reproducing the issue:

N/A

Other information about your system:

MSI gs65, intel i7 8750h, 32gb ram.

Other questions

Does the issue still occur after restarting your PC?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

Just tried with the current stable version.

davidacm added a commit to davidacm/nvda that referenced this issue Dec 11, 2019
davidacm added a commit to davidacm/nvda that referenced this issue Dec 13, 2019
michaelDCurran added a commit that referenced this issue Dec 15, 2019
@Adriani90 Adriani90 closed this Dec 15, 2019
@Adriani90

This comment has been minimized.

Copy link
Collaborator

@Adriani90 Adriani90 commented Dec 15, 2019

closing as fixed

@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.