Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the windows explorer in the open dialog file list file names are read twice #10620

Closed
zstanecic opened this issue Dec 13, 2019 · 12 comments · Fixed by #10750
Closed

In the windows explorer in the open dialog file list file names are read twice #10620

zstanecic opened this issue Dec 13, 2019 · 12 comments · Fixed by #10750

Comments

@zstanecic
Copy link
Contributor

@zstanecic zstanecic commented Dec 13, 2019

Steps to reproduce:

  1. for example, open the NVDA add-ons manager, and press on install add-on button.
  2. when pressed, the open dialog appears to chose the add-on.
  3. press shift+tab twice to go to the file list.
  4. find the desired file you need

Actual behavior:

file and folder names are pronounced twice, for example ad-on updater.nvda-addon, or the folder name add-ons add-ons

Expected behavior:

Folder and file names should be spoken once, as in NVDA 2019.2.1

System configuration

NVDA installed/portable/running from source:

installed and portable

NVDA version:

latest NVDA beta 2019.3 beta 1 and the last snap from the alpha branch

Windows version:

10.0.18363

Name and version of other software in use when reproducing the issue:

n/a

Other information about your system:

DualCore Intel Core i7-7500U, 3500 MHz (35 x 100),
8GB DDR 4 (2133)
tested also on my lenovo ideapad 320 15isk intel i3 6006U

Other questions

Does the issue still occur after restarting your PC?

yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

2019.2.1, this version pronounces file and folder names in the windows explorer open dialog file list once.

@XLTechie
Copy link
Contributor

@XLTechie XLTechie commented Dec 13, 2019

@XLTechie
Copy link
Contributor

@XLTechie XLTechie commented Dec 13, 2019

@lukaszgo1
Copy link
Contributor

@lukaszgo1 lukaszgo1 commented Dec 13, 2019

This is a duplicate of #2395 and it is definitely not a regression.

@zstanecic
Copy link
Contributor Author

@zstanecic zstanecic commented Dec 13, 2019

@zstanecic
Copy link
Contributor Author

@zstanecic zstanecic commented Dec 13, 2019

@lukaszgo1
Copy link
Contributor

@lukaszgo1 lukaszgo1 commented Dec 13, 2019

@zstanecic wrote;

Can you give arguments, why this is not a bug? Users see this like a bug, because it’s spurious

Where you've seen me saying that it is not a bug? I only said that it is not a regression because, well duplicate of issue from 2012 cannot be a regression, can it?

@XLTechie
Copy link
Contributor

@XLTechie XLTechie commented Dec 14, 2019

@Brian1Gaff
Copy link

@Brian1Gaff Brian1Gaff commented Dec 14, 2019

@zstanecic
Copy link
Contributor Author

@zstanecic zstanecic commented Dec 14, 2019

@feerrenrut
Copy link
Member

@feerrenrut feerrenrut commented Jan 29, 2020

I can reproduce this issue in 2019.3beta2 and also in 2019.2.1. While it is not a regression it would be good to fix it if we can. It won't get fixed for 2019.3.

@josephsl
Copy link
Collaborator

@josephsl josephsl commented Jan 29, 2020

@feerrenrut feerrenrut added this to Needs triage in 2019.3 via automation Jan 29, 2020
@feerrenrut feerrenrut moved this from Needs triage to Won't fix for 2019.3 in 2019.3 Jan 29, 2020
lukaszgo1 added a commit to lukaszgo1/nvda that referenced this issue Feb 3, 2020
@lukaszgo1
Copy link
Contributor

@lukaszgo1 lukaszgo1 commented Feb 3, 2020

@zstanecic Could you please try this build and confirm that items are no longer announced twice in places in which they previously were?

2019.3 automation moved this from Won't fix for 2019.3 to Closed Feb 6, 2020
feerrenrut pushed a commit that referenced this issue Feb 6, 2020
…sed via IAccessible (PR #10750)

Summary of the issue:

Windows Explorer list items repeat 'name' as the 'value' property. By default we are accessing it via UIA, and in this case the 'value' property was discarded. There are situations, such as NVDA's own open windows where UIA cannot be used (it causes freezes) and in these cases repetitions were annoying.

The fix:

Similar to what has been done for UIA value of these items is discarded when accessed via IAccessible

Fixes #10620  
Fixes #2395
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Feb 6, 2020
@feerrenrut feerrenrut removed this from the 2019.3 milestone Feb 6, 2020
@feerrenrut feerrenrut added this to the 2020.1 milestone Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
2019.3
Closed
7 participants