Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative dollar amounts not announced with minus symbol #10633

Closed
JamesCatt opened this issue Dec 17, 2019 · 3 comments · Fixed by #10636
Closed

Negative dollar amounts not announced with minus symbol #10633

JamesCatt opened this issue Dec 17, 2019 · 3 comments · Fixed by #10636
Milestone

Comments

@JamesCatt
Copy link
Contributor

@JamesCatt JamesCatt commented Dec 17, 2019

Steps to reproduce:

Create a web page with a negative dollar amount that uses the minus character (https://www.fileformat.info/info/unicode/char/2212/index.htm), such as <p>&minus;$100</p> and navigate to it with NVDA + any browser.

Actual behavior:

Amount reads as "one hundred dollars" with no mention of the minus symbol.

Expected behavior:

Amount reads as "minus one hundred dollars", the same as it would with a dash instead of minus symbol.

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

2019.2.1

Windows version:

Win10 x64 Home

Name and version of other software in use when reproducing the issue:

Firefox 72, Chrome 79

Other information about your system:

Other questions

Does the issue still occur after restarting your PC?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

2019.2, same.

Issue is likely due to only the dash character being included in the symbols dictionary, as well as the regex for negative amounts. Negative amounts were addressed by 0f437f0 but it looks like this only included the dash symbol, and not the actual minus symbol. Can also see more here: #3805 (comment)

@StommePoes

This comment has been minimized.

Copy link

@StommePoes StommePoes commented Jan 23, 2020

I have tried 2 synths (Microsoft Speech API and eSpeak NG) and under punctuation there's minus in a list of some punctuation (not much though and mostly emoji) where I've tried setting it to None, Some, and All. I also tried the other dropdown (Never, Always, and Always Below Symbol's Level. I'm not sure what that means).

None of these will read out any of my minuses: not the HTML named, decimal or hexidecimal character entity references, nor a direct copy/paste of the symbol directly.

However, I did a broad punctuation test about 2 years ago on multiple screen readers including NVDA, where in all tested SRs the minus worked (the dash did not, so it was before the change in #3805), so it's more like this is a regression rather than never-added.

Currently the hyphen-minus is reading as "minus" in NVDA. I'm not sure if I should use this symbol instead for current math projects I'm working on or if this issue will be fixed within the current school year.

@JamesCatt

This comment has been minimized.

Copy link
Contributor Author

@JamesCatt JamesCatt commented Jan 24, 2020

Currently the hyphen-minus is reading as "minus" in NVDA. I'm not sure if I should use this symbol instead for current math projects I'm working on or if this issue will be fixed within the current school year.

#10636 should address this, although I'm guessing the NVAccess team is busy with 2019.3 beta at the moment. Hoping they can get to my PR in time for the first 2020 release.

@StommePoes

This comment has been minimized.

Copy link

@StommePoes StommePoes commented Jan 25, 2020

I need to update my comment about the hyphen-minus: it's acting exactly as the dash currently: it'll say "minus" but only when directly prefacing a number. When I did my symbols test ~2 years ago, I could get the &minus; symbol read out reliably in NVDA regardless of where it was in text.

This was my testing page, taken from back when I was doing some math work for an educational company:
https://stommepoes.nl/work/symboltest.html

feerrenrut added a commit that referenced this issue Jan 28, 2020
Adds support for the Unicode minus symbol (U+2212), including when used for a negative number.

Fixes #10633
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Jan 28, 2020
@feerrenrut feerrenrut modified the milestones: 2019.3, 2020.1 Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.