New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heading level navigation keys #108

Closed
nvaccessAuto opened this Issue Jan 1, 2010 · 7 comments

Comments

Projects
None yet
2 participants
@nvaccessAuto

nvaccessAuto commented Jan 1, 2010

Reported by mohammed on 2008-06-12 08:08
new quick navigation keys to jump to a heading of level x where x is level 1 to 6.

where the page author is keen on structuring his page correctly, this feature can be very useful.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 1, 2010

Comment 1 by jteh on 2008-06-21 00:41
Changes:
Milestone changed from None to 0.6

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 1, 2010

Comment 2 by jteh on 2008-06-21 00:50
There are two possibilities that need to be considered:

  1. These keys could move to the next heading at the requested level regardless of headings at higher levels in between.
  2. These keys could only move to the next heading at the requested level if there are no headings at higher levels in between. For example, if you press "2", but there is a heading at level 1 closer to your current position, the key will not move to the heading at level 2.
    Option 1 is simpler to implement, but I know that some desire option 2. Any thoughts?
@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 1, 2010

Comment 3 by lpintes (in reply to comment 2) on 2008-06-21 08:05
Replying to jteh:
I am for the second option.

There are two possibilities that need to be considered:

  1. These keys could move to the next heading at the requested level regardless of headings at higher levels in between.
  2. These keys could only move to the next heading at the requested level if there are no headings at higher levels in between. For example, if you press "2", but there is a heading at level 1 closer to your current position, the key will not move to the heading at level 2.

Option 1 is simpler to implement, but I know that some desire option 2. Any thoughts?

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 1, 2010

Comment 4 by valiant8086 on 2008-06-22 01:46
I believe option two should be used. By that I mean if there is aheading level 1 heading next up and I try to go to heading level 2, I either can't do it because I'd be missing out on the heading level 1, or I just get told the upper level heading(s) and then proceed onto the next heading level 2, if that could be worked out it'd be best I think.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 1, 2010

Comment 5 by jteh on 2008-06-22 08:17
Changes:
Milestone changed from 0.6 to 0.6p2

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 1, 2010

Comment 6 by mdcurran on 2008-06-27 08:00
It seems that other particular screen readers we throught supported option 2 (not jumping past a higher heading) in fact don't do this, or at least, Jamie and I couldn't make it happen. This is also going to be a big problem on pages where the author hasn't used headings appropriately. This is sad, but probably more get it wrong than less, and limiting these keys may cause more confusion. However, we are happy to still continue conversation on whether option 2 should be implemented. If someone could also provide an example of a page where this feature does work with any other screen readers, that would be good.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 1, 2010

Comment 7 by mdcurran on 2008-06-27 08:04
Quick navigation keys for heading levels implemented in svn r2164. For now they only conform to option 1. A few non-trivial changes would need to be made to virtualBuffers to implement option 2 in the future, though its not completely impossible. For now this ticket is closed as the feature has been implemented according to the ticket summary. But, please continue the conversation on option 2 by replying to the previous comments.
Changes:
State: closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment