Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winamp support: NVDA doesn't detect the status of shuffle and repeat modes #10945

Closed
burakyuksek opened this issue Apr 6, 2020 · 1 comment · Fixed by #10947
Closed

Winamp support: NVDA doesn't detect the status of shuffle and repeat modes #10945

burakyuksek opened this issue Apr 6, 2020 · 1 comment · Fixed by #10947
Milestone

Comments

@burakyuksek
Copy link

burakyuksek commented Apr 6, 2020

Steps to reproduce:

  1. Start winamp
  2. Press r or s toggle shuffle or repeat
  3. NVDA will say "off" every time you toggle those modes

Actual behavior:

NVDA will say "off" every time you toggle those modes

Expected behavior:

NVDA needs to state if setting is on or off.

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

2019.3.1

Windows version:

Windows10 latest

Name and version of other software in use when reproducing the issue:

Winamp 5.666 Build 3516

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

No

If addons are disabled, is your problem still occuring?

Yes

Did you try to run the COM registry fixing tool in NVDA menu / tools?

No

@josephsl
Copy link
Collaborator

josephsl commented Apr 6, 2020

josephsl added a commit to josephsl/nvda that referenced this issue Apr 6, 2020
…er module. Re nvaccess#10945.

Python 3 defaults to Unicode strings, and without bytes conversion, FindWindowA will fail. Thus call winUser.FindWindow which eventually clals user32.dll::FindWindowW. This resolves shuffle and repeat status announcement.
michaelDCurran pushed a commit that referenced this issue Apr 7, 2020
* appModules/winamp: update copyright header

* appModules/winamp: call FindWindowW (widechar version) found in winUser module. Re #10945.

Python 3 defaults to Unicode strings, and without bytes conversion, FindWindowA will fail. Thus call winUser.FindWindow which eventually clals user32.dll::FindWindowW. This resolves shuffle and repeat status announcement.
@nvaccessAuto nvaccessAuto added this to the 2020.1 milestone Apr 7, 2020
@feerrenrut feerrenrut modified the milestones: 2020.1, 2020.2 Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants