Skip to content

Add ability to reset speech dictionaries to factory default #11802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Qchristensen opened this issue Nov 1, 2020 · 2 comments · Fixed by #13294
Closed

Add ability to reset speech dictionaries to factory default #11802

Qchristensen opened this issue Nov 1, 2020 · 2 comments · Fixed by #13294
Assignees
Milestone

Comments

@Qchristensen
Copy link
Member

Is your feature request related to a problem? Please describe.

If entries are made in the default or voice speech dictionaries, the only way to reset these is to go back in and delete them manually (or editing the file in NVDA's appdata).

To reset these to "factory defaults", you need to go in and remove all entries.

Describe the solution you'd like

Although removing all dictionary entries is easier than reverting all changes to the symbol pronunciation dialog manually, it would still be useful to have a button to either "Reset to factory defaults" or "Remove all" (which are basically the same thing).

The input gestures dialog has a "Reset to factory defaults" button, and issue #3762 proposes the ability to reset symbol pronunciation to defaults, so I have written this issue up to propose consistency across the three features.

Additionally I would propose that when implementing #6648, the dialog (confirming resetting NVDA to factory defaults) could offer the ability to also reset speech dictionaries (and punctuation / symbol pronunciation and gestures).

Describe alternatives you've considered

Currently it is psosible to delete all entries manually, however this could need to be done for each voice and the default dictionary. This issue also proposes a consistent approach to resetting speech dictionaries, punctuation / symbol pronunciation and gestures.

Additional context

@Adriani90
Copy link
Collaborator

cc: @JulienCochuyt

@JulienCochuyt
Copy link
Collaborator

Interestingly, the "Remove" button (removing a single entry) was historically designed to handle the removal of all the selected entries in a multi-selection list control. This idea seems to have been abandoned as the list control is explicitly set to support only a single selection - presumably for easier user interaction.

seanbudd pushed a commit to lukaszgo1/nvda that referenced this issue Feb 3, 2022
nvaccess#13294

Link to issue number:
Fixes nvaccess#11802
Supersedes nvaccess#12385

Summary of the issue:
The Speech Dictionary dialog lacks a "Remove all" button to ease clearing a whole dictionary.

Description of how this pull request fixes the issue:
Split both the DictionaryDialog and DictionaryEntryDialog from gui.settingsDialogs to a new dedicated gui.speechDict
Redeem copyright holders' names by blaming the history of source/gui/settingsDialogs.py
Linted the result in a separate commit for easier review and history tracking
Added a "Remove all" coherent with the "Restore to factory default" as found on the Input Gestures dialog
seanbudd added a commit that referenced this issue Feb 3, 2022
…er after abandoned #12385

Fixes #11802
Supersedes #12385

Summary of the issue:
The Speech Dictionary dialog lacks a "Remove all" button to ease clearing a whole dictionary.

Description of how this pull request fixes the issue:
Split both the DictionaryDialog and DictionaryEntryDialog from gui.settingsDialogs to a new dedicated gui.speechDict
Redeem copyright holders' names by blaming the history of source/gui/settingsDialogs.py
Linted the result in a separate commit for easier review and history tracking
Added a "Remove all" coherent with the "Restore to factory default" as found on the Input Gestures dialog
@nvaccessAuto nvaccessAuto modified the milestone: 2022.1 Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment