Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some graphical elements are not disabled in setting panels when they should #11809

Closed
CyrilleB79 opened this issue Nov 4, 2020 · 0 comments · Fixed by #11812
Closed

Some graphical elements are not disabled in setting panels when they should #11809

CyrilleB79 opened this issue Nov 4, 2020 · 0 comments · Fixed by #11812
Milestone

Comments

@CyrilleB79
Copy link
Collaborator

Steps to reproduce:

  1. Open braille setting panel
  2. Uncheck "Show cursor"
  3. Press Alt+F

Actual behavior:

At step 2, the edit field "Cursor blink rate (ms)" and the combo boxes "Cursor shape for focus:" and "Cursor shape for review:" are greyed out but not their associated label. For people with low vision, it is not so clear that these items are disabled.
At step 3, the focus movesto "Message timeout (sec)" field, whereas the acelerator key is alt+T, not alt+F.

Expected behavior:

At step 2., the labels should also be greyed out.
At step 3, the focus should not move since "Cursor shape for focus:" combo-box (having alt+f accelerator) is disabled.

System configuration

NVDA installed/portable/running from source:

Any

NVDA version:

2020.3

Windows version:

10

Name and version of other software in use when reproducing the issue:

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

2020.2 with same issue

If addons are disabled, is your problem still occuring?

Yes

Did you try to run the COM registry fixing tool in NVDA menu / tools?

No

Note

I have already a prototype branch to fix this issue. Coming soon.

feerrenrut pushed a commit that referenced this issue Nov 25, 2020
When wx controls (combo-box, edit, etc.) have an associated labels, disable the associated label when the control is disabled.
Fixes #11809
Co-authored-by: Reef Turner <reef@nvaccess.org>
@nvaccessAuto nvaccessAuto added this to the 2020.4 milestone Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants