Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvda does not announce the accentuation of the letter if the check box is Say capitalization before capitalization #11948

Closed
fernando-jose-silva opened this issue Dec 17, 2020 · 7 comments · Fixed by #11977
Milestone

Comments

@fernando-jose-silva
Copy link

Steps to reproduce:

Open a text editor
In the nvda speech settings select the checkbox
Say capitalization before capitalization
return to the text editor
turn on capslook
type letters with accents
examples:
Á
À
Ã
É
Ê
Í
Ó
Ô
Ú
read the accented letters typed with the left and right arrows

Actual behavior:

nvda informs
the character name is spoken
character accent is not spoken
is spoken capitalized

Expected behavior:

nvda informs:
speak the name of the character
speaks the accentuation of the character
speaks capital letter

System configuration

NVDA installed/portable/running from source:

instaled

NVDA version:

nvda.exe, NVDA alpha-21524,7b92e442

Windows version:

windows 10 19042.662

Name and version of other software in use when reproducing the issue:

any text editor

Other information about your system:

if the checkbox
Say capitalization before capitalization
is unchecked and the user chooses another way to receive the capitalization status of the letters, everything works fine.
In this case I want the nvda to announce the capitalization of the letters, and the accentuation of the letters as well.
tested with several synthesizers and the problem remains

Other questions

Does the issue still occur after restarting your computer?

yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

yes

If addons are disabled, is your problem still occuring?

yes

Did you try to run the COM registry fixing tool in NVDA menu / tools?

no

@CyrilleB79
Copy link
Collaborator

Hello @fernando-jose-silva

I have proposed a pull-request (#11977) that should fix this issue. Could you confirm that your issue disappear with this test build
Thanks.

@fernando-jose-silva
Copy link
Author

Thank you very much, the test compilation works correctly.

feerrenrut added a commit that referenced this issue Apr 21, 2021
Fixes #11948

# Summary of the issue:
As described in #11948, some letter with diacritic is not spelt correctly with some synth if "Say cap before capitale" is checked, e. g. 'À' is spelt 'cap A' instead of 'cap A grave'.
Looking at getSpellingSpeech function in speech\__init__.py, it appears that this is due to the fact that the string 'cap À' is passed to the synth in the speech sequence in such a case. But the synth is only asked to use character mode for the strings whose length is 1. This is wrong in this case, because 'cap' should be spoken with character mode off, but 'À' should be spoken with character mode on.

# Description of how this pull request fixes the issue:
In getSpellingSpeech, in the string sequence, I have separated the 'cap' message string from the character to be spelt. If the character to be spelt is of length 1, i.e. not replaced by symbol description or modified pronunciation, character mode is activated. If a string in the speech sequence has a length > 1, because it is a capitalization message or because it corresponds to a character description or symbol replacement, character mode is disabled.

Note that the 'cap' message can be of two types:
- with 'cap' indication before as in English: 'cap %s'
- with 'cap' indication after as in French: '%s majuscule'

Co-authored-by: Reef Turner <reef@nvaccess.org>
@nvaccessAuto nvaccessAuto added this to the 2021.1 milestone Apr 21, 2021
@ruifontes
Copy link
Contributor

Helo!
This fix, I think, have broken other parts...
Go to https://www.fnac.pt/SearchResult/ResultList.aspx?SCat=0%211&Search=band&sft=1&sa=0
In the first line NVDA should read:Botão Áreas
and read:
Botão Á reas

@CyrilleB79
Copy link
Collaborator

CyrilleB79 commented Jun 15, 2021

Hi @ruifontes
I cannot reproduce this issue on my side with eSpeak or IBMTTS.
Please open a new issue (bug template) and fill in all the requested paragraphs. Especially the following information would be useful: detailed steps to reproduce, specific configuration, synthesizer used (try with various synth please), log in debug mode, various NVDA versions tested (beta2 / 2020.4) and the corresponding result, test without add-ons, etc.
If it appears to be a regression of 2021.1beta, please indicate it clearly and Cc NVAccess people (@feerrenrut)
Since you think the issue is related to the current issue, also indicate it with a ref to the current issue or, better, to the corresponding pull-request.
Thanks.

@ruifontes
Copy link
Contributor

Hello!
In NVDA 2020.4 the log shows:
IO - speech.speak (01:05:41.034) - MainThread (7052):
Speaking [CallbackCommand(name=say-all:lineReached), 'clicável', 'Banner Secção', 'botão', 'Áreas', CallbackCommand(name=say-all:lineReached)]
DEBUG - speech.manager.SpeechManager.speak (01:05:41.034) - MainThread (7052):
SpeechManager- speak (priority <SpeechPriority.NORMAL: 0>): [CallbackCommand(name=say-all:lineReached), 'clicável  ', 'Banner Secção  ', 'botão  ', 'Áreas  ', CallbackCommand(name=say-all:lineReached)]
DEBUG - speech.manager.SpeechManager._queueSpeechSequence (01:05:41.035) - MainThread (7052):
SpeechManager- Out Seq: [[IndexCommand(7)], ['clicável  ', 'Banner Secção  ', 'botão  ', 'Áreas  ', IndexCommand(8)], [EndUtteranceCommand()]]
DEBUG - speech.manager.SpeechManager._queueSpeechSequence (01:05:41.035) - MainThread (7052):

In NVDA 2021.1 Beta1 the log shows:
IO - speech.speech.speak (23:48:47.779) - MainThread (13444):
Speaking ['botão', 'Á', 'reas']
DEBUG - speech.manager.SpeechManager.speak (23:48:47.780) - MainThread (13444):
SpeechManager- speak (priority <SpeechPriority.NORMAL: 0>): ['botão  ', 'Á  ', 'reas  ']
DEBUG - speech.manager.SpeechManager._queueSpeechSequence (23:48:47.781) - MainThread (13444):
SpeechManager- Out Seq: [['botão  ', 'Á  ', 'reas  ', IndexCommand(24)], [EndUtteranceCommand()]]

So, the major difference is:
2020.4 -> SpeechManager- Out Seq: [[IndexCommand(7)], ['clicável  ', 'Banner Secção  ', 'botão  ', 'Áreas  ', IndexCommand(8)], [EndUtteranceCommand()]]
2021.1 Beta1 -> SpeechManager- Out Seq: [['botão  ', 'Á  ', 'reas  ', IndexCommand(24)], [EndUtteranceCommand()]]

Still necessary to create an issue?

@CyrilleB79
Copy link
Collaborator

Yes open a new issue with all the information required by the template and also in my previous message.
For now, I am not able to reproduce.

@CyrilleB79
Copy link
Collaborator

@ruifontes could you indicate if you are still experimenting the issue you were describing?

  • If yes, please open a new issue as soon as possible with the detailed description. This would allow to avoid having a regression in the final release of NVDA 2021.1
  • If not please also indicate it here so that to clarify this. Also if an add-on or a specific configuration was responsible for the issue, please indicate it.
    Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants