Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No braille feedback in Windows Calculator #12268

Closed
dkager opened this issue Apr 4, 2021 · 10 comments · Fixed by #12486
Closed

No braille feedback in Windows Calculator #12268

dkager opened this issue Apr 4, 2021 · 10 comments · Fixed by #12486
Milestone

Comments

@dkager
Copy link
Collaborator

dkager commented Apr 4, 2021

Steps to reproduce:

  1. Open Windows Calculator.
  2. Type 2
  3. Type +
  4. Type 3
  5. Type = (or Enter)

Note that the new appmodule listens for the Enter key, but not the equals (=) key. However, both work to display the result. Speech reports the result when you press Enter, but braille provides no feedback regardless of what key you press.

Actual behavior:

The braille display continues to show "Display is 0".
There are two problems with this:

  1. As you type (without using speech) you cannot verify what you just entered.
  2. Once the result appears, you cannot read it unless you temporarily move the focus away from the display and back again.

Expected behavior:

The braille display shows each number, operator and result as you type.

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

2020.4

Windows version:

Version 10.0.19042 Build 19042

Name and version of other software in use when reproducing the issue:

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

Yes, it worked in NVDA 2019.3.

If add-ons are disabled, is your problem still occurring?

Yes

Did you try to run the COM registry fixing tool in NVDA menu / tools?

Yes

@josephsl
Copy link
Collaborator

josephsl commented Apr 4, 2021 via email

@josephsl
Copy link
Collaborator

Hi,

It looks like the accompanying pull request might be one of the last ones from me for now...

To Sean: smoke tests cannot be performed in the upcoming pull request because Calculator is a modern app not included in AppVeyor VM (the VM uses Windows Server 2016 or 2019, which do not come with apps such as Calculator).

Thanks.

josephsl added a commit to josephsl/nvda that referenced this issue May 26, 2021
…access#12268.

Braille output is missing when entering calculations, caused by the fact that NVDA will ignore 'displayUpdated' activity Id in consideration for speak typed characters being enabled. Therefore announce expressions in braille always.
josephsl added a commit to josephsl/nvda that referenced this issue May 26, 2021
…mands that should be announced. Re nvaccess#12268.

Add Delete and Numpad Delete (clear expression) commands to list of commands that should be reported.
josephsl added a commit to josephsl/nvda that referenced this issue May 26, 2021
…ccess#12268.

When results commands are performed (Escape, Enter, Delete), announce results in both speech and braille instead of speech alone.
@nvaccessAuto nvaccessAuto added this to the 2021.2 milestone May 31, 2021
@dreinn
Copy link

dreinn commented Sep 2, 2021

Don't work for me.
I'm trying it with NVDA 2021.2beta1, no Windows essential installed.
On my windows10 work pc version 10.0.19043, if I open the calculator, on the display i read "screen is 0".
I write:
2

The "2" sign is displayed for 1 second, then it returns to "screen is 0".
I add "+3" then enter.

for a second it appears "screen is 5", then again "screen is 0".

@CyrilleB79
Copy link
Collaborator

Same feedback for me.

Actually, I guess this behaviour was intended when developing the feature; @josephsl can you confirm this since you have used ui.message?
IMO the unique way to have this feature usable is to set up a profile for Windows Calculator and configuring braille messages to be displayed indefinitely.
But it is quite confusing for the users who do not know that they should change this option.
If nothing better could be done, at least this should be documented in the user guide.

@ruifontes
Copy link
Contributor

I am using the last Alpha, 23661,c45f5f76, and it works as expected...

@josephsl
Copy link
Collaborator

josephsl commented Sep 2, 2021 via email

@dkager
Copy link
Collaborator Author

dkager commented Sep 2, 2021

Could an alternative solution for the original problem, i.e. redundant speech output, perhaps be to ship a preset configuration profile for the Calculator app with NVDA? This profile would disable character echo. Then you can leave braille (and UIA, for that matter) alone.

@josephsl
Copy link
Collaborator

josephsl commented Sep 2, 2021 via email

@bdorer
Copy link
Sponsor

bdorer commented Sep 5, 2021

Hi, I vote for such profiles because users expect nvda to show braille output until something other happens. Users don't care how you provide data.

@CyrilleB79
Copy link
Collaborator

I think including a profile directly in NVDA release can be very confusing for the user experience of some. Users expect to have only default profile when they install NVDA and some are even not conscious at all to have a unique (default) profile active. Thus you can expect questions such as: "Why NVDA does not remember the voice rate if I change it while in Calculator?"

The problem is actually this one:

users expect nvda to show braille output until something other happens.

I have mentioned profiles just as a work-around. But this cannot be the solution for this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants