Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Braille input with NVDA isn't always correct #12667

Closed
Futyn-Maker opened this issue Jul 21, 2021 · 4 comments · Fixed by #12742 or #12850
Closed

Braille input with NVDA isn't always correct #12667

Futyn-Maker opened this issue Jul 21, 2021 · 4 comments · Fixed by #12742 or #12850
Labels
component/braille p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Milestone

Comments

@Futyn-Maker
Copy link

Steps to reproduce:

  1. Open NVDA braille settings and choose, for example, "unified English braille grade 1" as an input braille table (generally relevant for all braille tables).
  2. (for UEB) input with a braille display keyboard: ⠐⠣⠠⠉⠐⠜ (5-126-6-14-5-345). Another example: ⠐⠣⠼⠁⠐⠜ (5-126-3456-1-5-345). And many other examples.

Actual behavior:

For the first example: NVDA says: "Input isn't supported" when I try to input the caps indicator (dot 6) after '(' (dots 5-126) and ignores my input.
For the second example: NVDA says "Input isn't supported" when I try to input the number sign (3456) after '(' (5-126) and ignores my input.
Generally: something goes wrong with input multicellular signs after parentheses, quotes, brackets, dashes and other symbols.

Expected behavior:

Input should be processed correctly, number signs, caps indicators and other parts of multicellular symbols shouldn't be ignored.

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

2021.1

Windows version:

10

Name and version of other software in use when reproducing the issue:

Other information about your system:

I use the Focus 40 (4th generation) braille display.

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

If add-ons are disabled, is your problem still occurring?

Yes (including BrailleExtender)

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Other comments

I've found this problem when working on Russian Liblouis tables, but it's actual for all input tables.
It doesn't seem to be a problem of Liblouis because back translation in other programs used Liblouis (including lou_translate.exe) works correctly. I think that the problem is in how NVDA processes Liblouis tables.

@feerrenrut feerrenrut added this to the 2021.3 milestone Jul 22, 2021
@feerrenrut
Copy link
Contributor

@LeonarddeR Do you have any insight into this issue? I'd love to know if someone with a different braille display can reproduce the issue.

@seanbudd
Copy link
Member

Reopened due to #12742 being reverted by #12789

@seanbudd seanbudd reopened this Aug 29, 2021
@feerrenrut feerrenrut added the p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority label Sep 3, 2021
@lukaszgo1
Copy link
Contributor

@Futyn-Maker Would you be able to test with this try build?

@Futyn-Maker
Copy link
Author

@lukaszgo1 Seems to work as expected, without problems. Thanks!

seanbudd pushed a commit that referenced this issue Sep 23, 2021
…d braille tables when in text controls (#12850)

Fixes #12667

Summary of the issue:
When entering text from a braille display NVDA reports that it is unsupported even though entered combination is valid. This check has been introduced in #7843 to prevent a situation in which someone uses contracted table outside text content and enters a combination which cannot be converted to a single character (a good example is entering dots 356 using English UK Grade 2 which is a contraction for "was"). The check however was too broad and didn't take into account that for literary / computer braille tables single combination of dots can either always be converted to a single character, or if not it does not result in multiple characters i.e. number sign.

Description of how this pull request fixes the issue:
Now the check applies only when the table in use is contracted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/braille p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Projects
None yet
4 participants