Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Win11] NVDA is not announcing the current day (Sunday, Monday, etc.) properly in the calendar view. #12757

Closed
SMTestGH opened this issue Aug 20, 2021 · 2 comments · Fixed by #12862
Assignees
Labels
platform/Windows11 Issues specific to Windows 11
Milestone

Comments

@SMTestGH
Copy link

Steps to reproduce:

  1. Press Win+B to navigate to system tray
  2. Arrow to date/time control and open with Enter
  3. Tab to calendar grid
  4. Arrow left/right to a different day

Actual behavior:

NVDA abbreviates day of week to 2 letters: 26 data item ‎August‎ ‎2021 row 4 Th column 5

Expected behavior:

NVDA reads the date (i.e. 26 and the full day of the week (i.e. Monday, Tuesday)

System configuration

NVDA installed/portable/running from source:

Occurs when installed or portable

NVDA version:

2021.1

Windows version:

Name and version of other software in use when reproducing the issue:

Windows 11 Insider preview

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

No, but Narrator screen reader does not exhibit the same issue.

If add-ons are disabled, is your problem still occurring?

Yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Yes

@seanbudd seanbudd added this to the 2021.3 milestone Aug 23, 2021
@feerrenrut feerrenrut added the platform/Windows11 Issues specific to Windows 11 label Aug 23, 2021
@seanbudd seanbudd self-assigned this Sep 17, 2021
seanbudd added a commit that referenced this issue Sep 20, 2021
…k in full (#12862)

Fixes #12757

Summary of the issue:

While navigating the calendar, NVDA reads days as follows:
`26 data item ‎August‎ ‎2021 row 4 Th column 5` as opposed to `26 data item ‎August‎ ‎2021 row 4 Thursday column 5`.

The abbreviated days of the week, which make up the column headers of the table and aren't focusable, are read.
Instead, the UIA name of the column header should be read.

Description of how this pull request fixes the issue:

Adds: `UIATableItemPattern`, a small independent change that helped with investigating
Abstracts shared code from `_get_rowHeaderText` and `_get_columnHeaderText` into `_getTextFromHeaderElement`.
Overload `_getTextFromHeaderElement` in `CalendarViewDayItem` to read the correct label.

Manually tested with Win11 using reproduction steps from #12757

Further work could be done to parse the date information and localize it, instead of reporting it as a table cell.
@josephsl
Copy link
Collaborator

Hi,

The accompanying pull request also resolves this in Windows 10 (I suspect Version 1909 or later), so looks like an edit to what's new would be great before 2021.3 enters string freeze.

Thanks.

@seanbudd
Copy link
Member

Thanks @josephsl - see #12863.

seanbudd added a commit that referenced this issue Sep 20, 2021
Fixes the changelog message from #12862, for #12757

Summary of the issue:
Turns out that #12862 was also a Windows 10 issue, and #12757 fixed the issue in both cases.

Raised in this comment: #12757 (comment)

Description of how this pull request fixes the issue:
Changes the changelog message to be more general and consistent with other messages.
seanbudd added a commit that referenced this issue Sep 21, 2021
…k in full (#12862)

Fixes #12757

Summary of the issue:

While navigating the calendar, NVDA reads days as follows:
`26 data item ‎August‎ ‎2021 row 4 Th column 5` as opposed to `26 data item ‎August‎ ‎2021 row 4 Thursday column 5`.

The abbreviated days of the week, which make up the column headers of the table and aren't focusable, are read.
Instead, the UIA name of the column header should be read.

Description of how this pull request fixes the issue:

Adds: `UIATableItemPattern`, a small independent change that helped with investigating
Abstracts shared code from `_get_rowHeaderText` and `_get_columnHeaderText` into `_getTextFromHeaderElement`.
Overload `_getTextFromHeaderElement` in `CalendarViewDayItem` to read the correct label.

Manually tested with Win11 using reproduction steps from #12757

Further work could be done to parse the date information and localize it, instead of reporting it as a table cell.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/Windows11 Issues specific to Windows 11
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants