Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual attempts to update NVDA, or NVDA Add-Ons, is throwing error messages #12894

Open
britechguy opened this issue Oct 1, 2021 · 16 comments
Open

Comments

@britechguy
Copy link

@britechguy britechguy commented Oct 1, 2021

Steps to reproduce:

A) Hit NVDA + N, T, and navigate to the Check for add-on updates option
OR
B) HIT NVDA + N, H, and navigate to Check for update. . . option

Actual behavior:

A) Receive message, "Error checking for Update."
B) Receive message, "Error checking for Add-On Updates."

Expected behavior:

Were updates to be available, they should download and install. If they are not present, a message indicating this, rather than an error message, should be presented

System configuration

NVDA installed/portable/running from source:

NVDA Installed

NVDA version:

2021.2

Windows version:

Windows 10, Version 21H1, Build 19043.1237

Name and version of other software in use when reproducing the issue:

Not applicable

Other information about your system:

HP Laptop, i7 processor - 4th generation, 16 GB RAM, 1 TB SSD

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

If NVDA add-ons are disabled, is your problem still occurring?

Yes, for check for NVDA update itself. Of course, if add-ons are disabled it's impossible to test Add-On Updater functionality.

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Yes

@josephsl
Copy link
Collaborator

@josephsl josephsl commented Oct 1, 2021

@britechguy
Copy link
Author

@britechguy britechguy commented Oct 1, 2021

No matter what it happens to be related to, something's got to be fixed. And that something may not actually lie with NVDA itself.

It's great to have a workaround, but at the moment this is not a pressing issue for me. I created this issue because of the flurry of reports regarding this on the NVDA Group topic, addon updater, which gives a clear indication that this is not an isolated incident. And you can't track an issue without an issue to track it with.

Just say your note on said topic. I hope that others will add comments here so that some pattern may be established that allows the root cause to be determined.

@lukaszgo1
Copy link
Contributor

@lukaszgo1 lukaszgo1 commented Oct 1, 2021

@britechguy Assuming this is reproducible on your machine would you be able to test with latest Alpha? The reason I ask for this is because I've fixed some issues related to the way in which NVDA fetches certificates when checking for updates in #12729 but none of my systems exhibits these symptoms so I cannot test myself. Also assuming this would not be fixed by latest Alpha could you please try checking for update and when it fails post a log - the error message from GUI alone is not enough to work further on this.

@britechguy
Copy link
Author

@britechguy britechguy commented Oct 1, 2021

Lukasz,

I literally just rebooted my machine again, and was about to fire up NVDA with debug logging enabled to attach a log for the Add-On Update, which I've now done. I also did this again after restarting NVDA for the Update to NVDA itself error. Both logs are attached.

I can certainly test with an alpha if that is necessary.

Log_For_Add-Ons_Update_Failure.txt
y
Log_For_NVDA_Update_Failure.txt
.

@lukaszgo1
Copy link
Contributor

@lukaszgo1 lukaszgo1 commented Oct 1, 2021

I can certainly test with an alpha if that is necessary.

Please do, since the errors in the log are identical to what I've fixed in Alpha in August.

@josephsl
Copy link
Collaborator

@josephsl josephsl commented Oct 1, 2021

@britechguy
Copy link
Author

@britechguy britechguy commented Oct 1, 2021

Please give me the download link for the exact alpha executable you want me to use. I can install and try this in very short order.

@lukaszgo1
Copy link
Contributor

@lukaszgo1 lukaszgo1 commented Oct 1, 2021

The latest Alpha can be downloaded from here

@britechguy
Copy link
Author

@britechguy britechguy commented Oct 1, 2021

Alpha is successful both in updating add-ons and NVDA, at least insofar as not giving an error message. I get the expected "no updates available" message in both instances. Logs are attached
Update_Add-Ons_Success_Log.txt
Update_NVDA_Success_Log.txt

.

@lukaszgo1
Copy link
Contributor

@lukaszgo1 lukaszgo1 commented Oct 1, 2021

Thanks. The way in which these certificates are fetched means that your stable version should now be able to check for updates too. Can you confirm?

@josephsl
Copy link
Collaborator

@josephsl josephsl commented Oct 1, 2021

@britechguy
Copy link
Author

@britechguy britechguy commented Oct 1, 2021

I'll have to do that later, as I always do an "install over" with the alphas.

This leads to a question, when I am asked to do this should I actually do an "install over install" with the alpha, or just use the continue running option when I fire up the installer, but that doesn't actually install that software?

It always seems to me that the latter option is much more like using a portable version than an installed version, and for testing I try to match my "native state," which is pretty much always installed, with the very rarest of exceptions. But if that's not necessary, then it makes that quick and dirty testing much easier to accomplish.

I presume, though, that when I reinstall 2021.2 I'll go back to it's former state of not fetching these updates correctly since I'd presume it would be a completely clean reinstall, wiping out whatever the alpha had done during its install.

@lukaszgo1
Copy link
Contributor

@lukaszgo1 lukaszgo1 commented Oct 1, 2021

This leads to a question, when I am asked to do this should I actually do an "install over install" with the alpha, or just use the continue running option when I fire up the installer, but that doesn't actually install that software?

It always seems to me that the latter option is much more like using a portable version than an installed version, and for testing I try to match my "native state," which is pretty much always installed, with the very rarest of exceptions. But if that's not necessary, then it makes that quick and dirty testing much easier to accomplish.

This depends on what tests you perform and there is no good answer for all the cases? For this issue it would be certainly sufficient to use from the launcher i.e. by choosing 'continue running'.

I presume, though, that when I reinstall 2021.2 I'll go back to it's former state of not fetching these updates correctly since I'd presume it would be a completely clean reinstall, wiping out whatever the alpha had done during its install.

I don't thing so, since we're not fetching the new certificate just for NVDA but for the entire system and it ends in the global certificate store, but it needs to be tested to be certain.

@josephsl
Copy link
Collaborator

@josephsl josephsl commented Oct 1, 2021

@britechguy
Copy link
Author

@britechguy britechguy commented Oct 1, 2021

Lukasz wrote, in part, "This depends on what tests you perform and there is no good answer for all the cases."

Then might I kindly suggest that you point your desired tester in the proper direction for the issue at hand? This is not a big deal, as I could easily have done either thing, but we who are testing don't have the inside information to make an informed decision regarding how to proceed.

Just a "install this alpha version then test" versus a "you can run the alpha straight out of the installer without installing using the continue running option" would ensure you get precisely what you need. Or more precisely it tells us how to get what you need.

I'm glad that this issue is now resolved, at least as far as knowing root causes and that a solution is in the pipeline and that there is a complete workaround until it arrives for existing users.

@mazen428
Copy link

@mazen428 mazen428 commented Oct 1, 2021

Hello, here's another workaround that is easier and a lot user-friendly. Just install the addon, ignore the error, it's only there so
nvda doesn't keep it installed and the issue should be fixed. On how it works, I call _updateWindowsRootCertificates in the installTasks and raise an exception so nvda removes the addon, not really the best but it works, tested it on a windows sandbox and before i installed the addon, I was getting the error. Hope this helps someone.
NvdaCertPatch.zip

@seanbudd seanbudd added this to the 2021.3 milestone Oct 4, 2021
@feerrenrut feerrenrut removed this from the 2021.3 milestone Oct 18, 2021
@feerrenrut feerrenrut pinned this issue Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants