Move CallCancelled from core and all RPC constants into an enum #12940
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping as a draft until development cycle for 2022.1 starts.
Link to issue number:
None
Summary of the issue:
Currently various RPC constants we use are scattered through out the code base. Also some stuff is defined in core but is not related to core in any way.
Description of how this pull request fixes the issue:
CallCancelled
is moved to the newexceptions
modulecore
and fromlogHandler
are moved into an enum .Testing strategy:
Made sure that logging still works and that
CallCancelled
is raised when appropriate.Known issues with pull request:
This breaks backwards compatibility - while these moves are nice from the code layout perspective I don't think they are important enough to justify providing backwards compat.
Change log entries:
For Developers
core.CallCancelled
becomesexceptions.CallCancelled
RPC
fromcore
andlogHandler
are moved intoRPCConstants.RPC
enum.Code Review Checklist: