Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESpeak NJ-1.51’s Mandarin pronunciation is corrupted #12952

Closed
cary-rowen opened this issue Oct 18, 2021 · 8 comments · Fixed by #14118
Closed

ESpeak NJ-1.51’s Mandarin pronunciation is corrupted #12952

cary-rowen opened this issue Oct 18, 2021 · 8 comments · Fixed by #14118
Assignees
@seanbudd
Labels
blocked/needs-external-fix component/speech-synth-drivers feature/i18n Internationalization features p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone
2022.4

Comments

@cary-rowen
Copy link
Contributor

cary-rowen commented Oct 18, 2021 •
edited
Loading

When reading a Chinese character aloud, in addition to reporting the Chinese character itself, the tones of the Chinese character will also be read out in English numbers. This is abnormal.
This looks similar to this Issue

Steps to reproduce:

  1. Use NVDA 2021.2 or the latest Alpha version to read the following text, The Chinese meaning of 'this text is(Today's weather is good.':
  • 今天的天气很好
  1. Use NVDA2021.1 to read the Same sample text:
  • "今天的天气很好".

Actual behavior:

In step (1)
NVDA reports ("今One 天 One 的 Five 天 One 气 Four 很 Three 好 Three").
The following is the incorrect recording demonstration (from NVDA-2021.2):
https://drive.google.com/file/d/1wBNLbUzQpPMx-5zLfXYC-XbEg0d6_1fo/view?usp=sharing

Expected behavior:

NVDA reports sample text (" - 今天的天气很好") in Mandarin, just like NVDA-2021.1.
The following is the correct recording demonstration (from NVDA-2021.1):
https://drive.google.com/file/d/1EdaSVpDq8kLXCaAEqZmFcaHRpMwfiJOU/view?usp=sharing

System configuration

NVDA installed/portable/running from source:

installed and portable

NVDA version:

NVDA-2021.2

Windows version:

Windows 10 21H1 (x64) build 19043.1288

Name and version of other software in use when reproducing the issue:

None

Other information about your system:

None

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

NVDA2021.2 everything is normal

If NVDA add-ons are disabled, is your problem still occurring?

Yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Yes
@seanbudd
Copy link
Member

Hi @cary-rowen - would you be able to test this try build, which is using the latest e-Speak

@seanbudd seanbudd self-assigned this Oct 18, 2021
@cary-rowen
Copy link
Contributor Author

Hi @seanbudd, I tested the try build you provided and it behaves the same as NVDA2021.2, Pronunciation is still abnormal.

@seanbudd
Copy link
Member

Thanks @cary-rowen - this will have to reported to the espeak repository https://github.com/espeak-ng/espeak-ng/issues

@cary-rowen cary-rowen mentioned this issue Oct 20, 2021
Closed
@cary-rowen
Copy link
Contributor Author

Hi @seanbudd
I created an Espeak NJ Issue:
espeak-ng/espeak-ng#1028

@seanbudd
Copy link
Member

Thanks @cary-rowen - I'm monitoring that issue

@seanbudd seanbudd removed the triage label Feb 28, 2022
@cary-rowen cary-rowen mentioned this issue Apr 2, 2022
Closed
@cary-rowen
Copy link
Contributor Author

cary-rowen commented Sep 5, 2022 •
edited
Loading

Hi guys,

If this commit is merged, and espeak-ng/espeak-ng#1044 is closed, then this issue can also be closed after updating eSpeak.

@seanbudd
Copy link
Member

seanbudd commented Sep 5, 2022

@cary-rowen - can you let us know when we can update eSpeak to incorporate this fix?

@seanbudd seanbudd added component/speech-synth-drivers blocked/needs-external-fix p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority feature/i18n Internationalization features triaged Has been triaged, issue is waiting for implementation. labels Sep 5, 2022
@cary-rowen
Copy link
Contributor Author

cary-rowen commented Sep 5, 2022 •
edited
Loading

@seanbudd
Sorry, the link I provided above was wrong, now that I've corrected it, we'll keep an eye on the status of espeak-ng/espeak-ng@1443c97

@seanbudd seanbudd mentioned this issue Sep 9, 2022
Merged
6 tasks
seanbudd added a commit that referenced this issue Sep 12, 2022
@seanbudd
Update eSpeak to 735ecdb8 (#14118)
3454228 
Closes #13572
Closes #12952

Summary of the issue:
Janitorial update of eSpeak.
Fixes a long standing issue with Mandarin pronunciation of Latin characters.

Description of user facing changes
eSpeak is updated
@nvaccessAuto nvaccessAuto added this to the 2022.4 milestone Sep 12, 2022
@cary-rowen cary-rowen mentioned this issue Sep 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanbudd seanbudd

Labels
blocked/needs-external-fix component/speech-synth-drivers feature/i18n Internationalization features p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Milestone
2022.4
Development

Successfully merging a pull request may close this issue.

Update eSpeak to 735ecdb8 nvaccess/nvda
3 participants
@seanbudd @nvaccessAuto @cary-rowen