Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support building with Visual Studio 2022 #13033

Closed
LeonarddeR opened this issue Nov 4, 2021 · 8 comments · Fixed by #13055 or #13524
Closed

Support building with Visual Studio 2022 #13033

LeonarddeR opened this issue Nov 4, 2021 · 8 comments · Fixed by #13055 or #13524
Labels
blocked component/build Official builds
Milestone
2022.2

Comments

@LeonarddeR
Copy link
Collaborator

LeonarddeR commented Nov 4, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.

Visual Studio 2022 is to be released next week. NVDA builds with Visual Studio 2019.

Describe the solution you'd like

Support building with Visual Studio 2022. We can decide to support 2019 and up, but as soon as appveyor supports 2022, it makes sense to drop 2019 support altogether.

Additional context

Blocked by a new SCons release. Visual Studio 2022 support is in master but is awaiting a new release.
@seanbudd
Copy link
Member

AppVeyor now supports this: https://www.appveyor.com/blog/2021/11/10/visual-studio-2022-image/

@LeonarddeR
Copy link
Collaborator Author

LeonarddeR commented Nov 11, 2021 via email

@LeonarddeR LeonarddeR mentioned this issue Nov 11, 2021
Merged
5 tasks
@nvaccessAuto nvaccessAuto added this to the 2022.1 milestone Nov 21, 2021
@michaelDCurran michaelDCurran mentioned this issue Feb 23, 2022
Merged
5 tasks
@LeonarddeR
Copy link
Collaborator Author

This was reverted by #13387

@LeonarddeR LeonarddeR reopened this Feb 24, 2022
@seanbudd seanbudd removed this from the 2022.1 milestone Mar 3, 2022
@LeonarddeR
Copy link
Collaborator Author

The fact that the uia library doesn't build on VS2022 is definitely an issue in our build environment. Running msbuild from the vs2022 developer command prompt works just fine.

@LeonarddeR LeonarddeR mentioned this issue Mar 23, 2022
Merged
5 tasks
@nvaccessAuto nvaccessAuto added this to the 2022.2 milestone Mar 24, 2022
michaelDCurran pushed a commit that referenced this issue Mar 24, 2022
@LeonarddeR
Restore VS2022 support (#13524)
7f53efd 
Fix-up of #13387
Fixes #13033

Summary of the issue:
Pr #13387 introduced support for custom UIA extensions, there by using the Microsoft UIA Automation remote operations library. This pr disabled building support for Visual Studio 2022. This has now been solved.

Description of how this pull request fixes the issue:
Fixes build on Visual Studio 2022 by ensuring that the windir environment variable is available. This should eventually be fixed in scons itself, though there's a note in their source code stating that adding environment variables to the basic set that's imported from os.environ should be considered very carefully.
@codeofdusk
Copy link
Contributor

This issue should be reopened, since NVDA doesn't yet support building with VS 2022 build tools. Is this still under investigation and blocked by issues in the UIA remote ops library?

@LeonarddeR
Copy link
Collaborator Author

LeonarddeR commented Jul 11, 2022 via email

@cary-rowen
Copy link
Contributor

@codeofdusk
I seem to have the same problem.

@LeonarddeR
@seanbudd
Can you investigate this?

@LeonarddeR
Copy link
Collaborator Author

LeonarddeR commented Jul 14, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked component/build Official builds
Projects
None yet
Milestone
2022.2
Development

Successfully merging a pull request may close this issue.

Allow building on Visual Studio 2022 LeonarddeR/nvda
Restore VS2022 support LeonarddeR/nvda
5 participants
@codeofdusk @LeonarddeR @seanbudd @nvaccessAuto @cary-rowen