Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVDA seems not to support Notepad++ 8.3 #13311

Closed
AAClause opened this issue Feb 6, 2022 · 8 comments · Fixed by #13364
Closed

NVDA seems not to support Notepad++ 8.3 #13311

AAClause opened this issue Feb 6, 2022 · 8 comments · Fixed by #13364
Milestone

Comments

@AAClause
Copy link
Contributor

AAClause commented Feb 6, 2022

Steps to reproduce:

  1. Start Notepad++ 8.3 (downloadable here), you should have a blank document.
  2. Write some text (just one character is enough).

Alternatively, with an installed version you can just open a file from explorer.

Actual behavior:

Notepad++ crashes (the app closes), NVDA fails to retrieve file content.

Expected behavior:

No crash, access to file content.

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

alpha-24583,61000de2

Windows version:

10 21H2

Name and version of other software in use when reproducing the issue:

Notepad++ 8.3 (installed and portable versions)

Other information about your system:

N/A

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

No. But no problem with Notepad++ 8.2.1 and earlier.

If add-ons are disabled, is your problem still occurring?

Yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Yes

@cary-rowen
Copy link
Contributor

I can also reproduce this.
@seanbudd
@feerrenrut
can you take a look at this?

@AAClause
Copy link
Contributor Author

AAClause commented Feb 8, 2022

Out of curiosity, I've just tested with JAWS 2022: also no access to file contents but Notepad++ doesn't crash.

@MichelSuch
Copy link
Contributor

MichelSuch commented Feb 8, 2022 via email

@AAClause
Copy link
Contributor Author

AAClause commented Feb 8, 2022

@MichelSuch yes but Narrator doesn't work with Notepad++ 8.2 also.

@cary-rowen
Copy link
Contributor

Does this mean we are going to write an issue in the notepad++ repository

@TheQuinbox
Copy link
Contributor

I opened an issue before I knew this was related to NVDA actually, notepad-plus-plus/notepad-plus-plus#11133

@rezabakhshilaktasaraei
Copy link

Today, I downloaded Notepad++ 8.3, and I understood that it is not accessible for us. It means that when I type some Characters and navigate to read what every I typed, but NVDA doesn’t read anything. I don’t have this issue in 8.2, too.

@lukaszgo1
Copy link
Contributor

If someone is interested in testing you can do so with this try build

seanbudd pushed a commit that referenced this issue Feb 22, 2022
Fixes #13311

Summary of the issue:
NVDA causes a crash when interacting with 64-bit builds of Notepad+++ 8.3. This happens because Notepad++ developers decided to deviate from the official Scintilla interface (they character points are represented by longlong rather than long in 64-bit builds). Since this allowed them to introduce the support for much bigger files this change is going to stay and NVDA has to adapt (see explanations in notepad-plus-plus/notepad-plus-plus#11133).

Description of how this pull request fixes the issue:
For 64-bit builds of Notepad++ 8.3 and above longlong is used for representing characters points.

Testing strategy:

- Notepad++ 8.3 x64 no longer crashes and text can be read normally.
- 32-bit build of the same version of NPP works as well as it used to before this change.
- Older version of Notepad++ x64 works normally and long is used for characters points there.
- Different editor (teXnicCenter) using Scintilla is not negatively affected.
- The newly introduced appmodule can be imported by using from nvdaBuiltin.appModules import notepadPlusPlus in an add-on.
@nvaccessAuto nvaccessAuto added this to the 2022.1 milestone Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants