Skip to content

Unlock the mouse buttons when exiting NVDA #13410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CyrilleB79 opened this issue Mar 1, 2022 · 10 comments · Fixed by #13529
Closed

Unlock the mouse buttons when exiting NVDA #13410

CyrilleB79 opened this issue Mar 1, 2022 · 10 comments · Fixed by #13529
Milestone

Comments

@CyrilleB79
Copy link
Collaborator

This feature request comes from a discussion on a French mailing list.

Is your feature request related to a problem? Please describe.

The user has accidentally locked one of the mouse button with shift+PavNum*without realizing it while working in Windows Explorer. Then he noticed unexpected behaviors such as arrow keys not working or not reporting anything when trying to navigate in Windows Explorer.

He has tried to restart NVDA but this did not solve the issue. Thus he was thinking to a Windows issue.

Describe the solution you'd like

The user suggests the following solution:
When exiting NVDA with insert +q, NVDA should unlock the mouse buttons if the button was originally locked by an NVDA command.

Describe alternatives you've considered

The real issue is that a screenreader user may forget that he has locked a mouse button with a screenreader command. On the contrary, a mouse user does not forget to release the pressure on the mouse button when needed.

Other solutions to this issue can be thought. For example a sound notification each 10 seconds to record the user that a button should be unlocked.

Additional context

None

@XLTechie
Copy link
Collaborator

XLTechie commented Mar 1, 2022 via email

@seanbudd
Copy link
Member

seanbudd commented Mar 9, 2022

@XLTechie - this would make a good feature request in a separate issue

@mwhapples
Copy link
Collaborator

I have made a pull request which fixes this. The only thing I was unsure about is whether the unlocking should be announced or should happen silently.

@XLTechie
Copy link
Collaborator

XLTechie commented Mar 23, 2022 via email

@mwhapples
Copy link
Collaborator

I have updated the pull request so that unlocking is announced.

seanbudd pushed a commit that referenced this issue Mar 30, 2022
Link to issue number:
#13410

Summary of the issue:
If the user locks a mouse button and then exits NVDA, the mouse button remains locked.

Description of how this pull request fixes the issue:
The mouse button states are checked in terminate() of the mouseHandler and unlocks the mouse buttons as required.
@CyrilleB79
Copy link
Collaborator Author

@seanbudd this issue has been fixed by the merge of #13529.
Thus it should be closed and added to milestone 2022.2.

I could close this issue but not add the milestone 2022.2.

@XLTechie
Copy link
Collaborator

XLTechie commented Mar 31, 2022 via email

@CyrilleB79
Copy link
Collaborator Author

If you read the initial description and the following discussion, you can see that this issue focused on releasing mouse buttons when NVDA exits. I can change the title for clarity if you want, e.g.: A way to avoid forgetting a locked mouse button when exiting NVDA.

On the contrary, #13446 focuses on a feature reminding regularly that a mouse button is down.

If you consider that something in this issue is not fixed by #13529, nor covered by #13446, please be more specific. Thanks.

@seanbudd
Copy link
Member

@CyrilleB79 - I agree, but I think this issue title is misleading. I'm going to change it, add the milestone, and close.
Feel free to re-edit the title further.

@seanbudd seanbudd changed the title A way to avoid forgetting a locked mouse button Unlock the mouse button when exiting NVDA Mar 31, 2022
@seanbudd seanbudd added this to the 2022.2 milestone Mar 31, 2022
@seanbudd
Copy link
Member

Closed by #13529

@seanbudd seanbudd linked a pull request Mar 31, 2022 that will close this issue
5 tasks
@seanbudd seanbudd changed the title Unlock the mouse button when exiting NVDA Unlock the mouse buttons when exiting NVDA Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants