Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 10/11 Start menu search: NVDA does not announce search results with details when tabbing through results #13544

Closed
josephsl opened this issue Mar 27, 2022 · 0 comments · Fixed by #13620
Labels
app/windows-interface Interactions between NVDA and the default Windows GUI feature/windows-explorer Windows start menu, explorer, and other in-box functionality. p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone

Comments

@josephsl
Copy link
Collaborator

Hi,

This is a 2022 update to #10329

Background:

From time to time Microsoft makes server side changes to Windows Search experience, including Start meu search box in Windows 10 and 11. With a new layout implemented in 2020 or so, NVDA does not announce search results with details, more prominent when tabbing through results in Windows 11.

Steps to reproduce:

Method 1: scroll through search results

  1. Press Windows key to open Start menu.
  2. Type something.
  3. When the first search result is dislayed, press down arrow to review results.

Method 2: tab through search results

  1. Open Start menu.
  2. Type something.
  3. Wen the first result is displayed, press Tab to move through results.

Actual behavior:

  • Method 1: NVDA does not announce search details such as category (app, web, etc.) when pressing down arrow to review results.
  • Method 2: NVDA is silent when moving to search categories.

Expected behavior:

NVDA announces results with details.

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

alpha-25094,307c8902

Windows version:

Windows 11 Version 21H2 (build 22000)

Name and version of other software in use when reproducing the issue:

None

Other information about your system:

While the version shown is for the stable Windows 11 release, the computer is used to test virtual machines, including older and newer Windows releases

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

2019.2 and later (the latest version installed on a virtual machine running Windows 10 Version 1803, the first release with this problem)

If NVDA add-ons are disabled, is your problem still occurring?

Yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Not applicable

Solution

In SearchUI app module (specifically, when choosing suggestion list item in overlay classes chooser), in addition to checking for object parent, also check if obj.parent.parent is indeed a results list. A more useful solution would be window class names, but the same class name is used in places other than results list, which can confuse NVDA and users as to what to do.

A prototype of this fix will be part of Windows App Essentials add-on development snapshot for March 28, 2022 (prototype testing in progress), and eventually will be proposed as a pull request in mid-April at the earliest.

Thanks.

@feerrenrut feerrenrut added p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority app/windows-interface Interactions between NVDA and the default Windows GUI feature/windows-explorer Windows start menu, explorer, and other in-box functionality. triaged Has been triaged, issue is waiting for implementation. labels Mar 28, 2022
josephsl added a commit to josephsl/nvda that referenced this issue Apr 20, 2022
…m. Re nvaccess#13544.

Windows Search user interface has changed in 2019, causing NVDA to not announce search result details. This is because suggestion list items are now grandchildren of the results list, not its children. Therefore also check grandparent object when detecting suggestion list items, allowing NVDA to announce result details on Windows 10 and 11.
josephsl added a commit to josephsl/nvda that referenced this issue Apr 21, 2022
…m. Re nvaccess#13544.

Windows Search user interface has changed in 2019, causing NVDA to not announce search result details. This is because suggestion list items are now grandchildren of the results list, not its children. Therefore also check grandparent object when detecting suggestion list items, allowing NVDA to announce result details on Windows 10 and 11.
josephsl added a commit to josephsl/nvda that referenced this issue Apr 21, 2022
…m. Re nvaccess#13544.

Windows Search user interface has changed in 2019, causing NVDA to not announce search result details. This is because suggestion list items are now grandchildren of the results list, not its children. Therefore also check grandparent object when detecting suggestion list items, allowing NVDA to announce result details on Windows 10 and 11.
seanbudd added a commit that referenced this issue Apr 26, 2022
… redesign applied (#13620)

Fixes #13544

Summary of the issue:
In 2019, Start menu/Windows Search UI has changed, causing NVDA to not announce search result details. This was traced to search result items being grandchildren of the results list.

Description of how this pull request fixes the issue:
In addition to lint and documentation update, check the instance of the obj.parent.parent (grandparent) to make sure it is results list so NVDA can announce search result details. This is applicable to Windows 10 and 11.

* appModules/searchui: update copyright header

* SearchUI: check grandparent object when detecting suggestion list item. Re #13544.

Windows Search user interface has changed in 2019, causing NVDA to not announce search result details. This is because suggestion list items are now grandchildren of the results list, not its children. Therefore also check grandparent object when detecting suggestion list items, allowing NVDA to announce result details on Windows 10 and 11.

* SearchUI: expand introductory comment to include the fact that alias app modules exist to handle later Windows releases.

Alias app modules fos SearchUI app module:
* searchapp: Windows 10 Version 2004 and later
* searchhost: Windows 11
Although alias app modules do have intro comments, add a comment to the base app module as well.

* appModules/searchui: general lint (Flake8 E231, E302)

* update changes

Co-authored-by: Sean Budd <sean@nvaccess.org>
@nvaccessAuto nvaccessAuto added this to the 2022.2 milestone Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app/windows-interface Interactions between NVDA and the default Windows GUI feature/windows-explorer Windows start menu, explorer, and other in-box functionality. p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants