Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please default ESpeak NG's voice role to "Chinese (Mandarin, latin as Pinyin)" for Chinese to fix #12952 #13572

Closed
cary-rowen opened this issue Apr 2, 2022 · 12 comments · Fixed by #14118
Labels
blocked/needs-external-fix component/i18n existing localisations or internationalisation component/speech-synth-drivers p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone

Comments

@cary-rowen
Copy link
Contributor

Is your feature request related to a problem? Please describe.

#12952 makes ESpeak completely unusable for Chinese users. This is a disaster for beginners who cannot use Windows OneCore.

Describe the solution you'd like

After testing, setting the voice role of ESpeak NG to "Chinese (Mandarin, latin as Pinyin)" can temporarily solve #12952 .
The word "temporarily" is used because the English pronunciation of "Chinese (Mandarin, latin as Pinyin" is less vivid than the current default "Chinese (Mandarin, latin as English)".
But this solution can get rid of the dilemma of not being able to use ESpeak NG at all.

Describe alternatives you've considered

The best solution is to solve #1028 by ESpeak.
Make "Chinese (Mandarin, latin as English)" can speak Chinese correctly.

Additional context.

I think this question is urgent enough, especially for beginners of nvda.

@Brian1Gaff
Copy link

Brian1Gaff commented Apr 3, 2022 via email

@cary-rowen
Copy link
Contributor Author

@Brian1Gaff
Sorry, I'm just a regular user, please give some explanation as useful as possible why I can't ask this request in the NVDA Repo.
I obviously see other screen reader that use the same version of ESpeak as nvda but default to the correct Chinese Mandarin voice.

@cary-rowen
Copy link
Contributor Author

Still thanks for your suggestion, I'll make the same request in the ESpeak repo if possible.

@feerrenrut
Copy link
Contributor

@feerrenrut
Copy link
Contributor

Note, the default / preference for the voice for a certain language code is controlled by espeak-ng.
This will also need to be reported to espeak as per espeak-ng/espeak-ng#1028

@cary-rowen
Copy link
Contributor Author

hi @feerrenrut

Unfortunately #12950 doesn't change anything for that.
I have made the request in ESpeak NJ repo,
please see here

Thanks

@cary-rowen
Copy link
Contributor Author

Hi,
@feerrenrut
This issue doesn't seem to get enough attention in ESpeak, and I'm wondering how this can be advanced.
Thanks

@cary-rowen
Copy link
Contributor Author

cary-rowen commented Sep 5, 2022

Hi guys,

If this commit is merged, and espeak-ng/espeak-ng#1044 is closed, then this issue can also be closed after updating eSpeak.

@seanbudd
Copy link
Member

seanbudd commented Sep 5, 2022

Can you let us know when we can update eSpeak to close this issue

@seanbudd seanbudd added component/i18n existing localisations or internationalisation blocked/needs-external-fix p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority component/speech-synth-drivers triaged Has been triaged, issue is waiting for implementation. labels Sep 5, 2022
@cary-rowen
Copy link
Contributor Author

cary-rowen commented Sep 5, 2022

@seanbudd
Sorry, the link I provided above was wrong, now that I've corrected it, we'll keep an eye on the status of espeak-ng/espeak-ng@1443c97

@cary-rowen
Copy link
Contributor Author

@seanbudd
The commit I mentioned in the above comment has been merged, can we now update eSpeak NG in NVDA to solve the problem for Chinese users?
This problem directly prevents Chinese users using Windows7 from using eSpeak to complete the installation of NVDA, and it should even be fixed in 2022.3Beta.

@seanbudd
Copy link
Member

seanbudd commented Sep 9, 2022

@cary-rowen - 2022.3beta is well and truly closed to new features. We will try to update eSpeak again for 2022.4

seanbudd added a commit that referenced this issue Sep 12, 2022
Closes #13572
Closes #12952

Summary of the issue:
Janitorial update of eSpeak.
Fixes a long standing issue with Mandarin pronunciation of Latin characters.

Description of user facing changes
eSpeak is updated
@nvaccessAuto nvaccessAuto added this to the 2022.4 milestone Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked/needs-external-fix component/i18n existing localisations or internationalisation component/speech-synth-drivers p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants