-
-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The name of the unit for the font size in the formatting information provided by NVDA is not localized #13573
Comments
In notepad (at least on Windows 10), there is no such formatting information. On my system, I have no translation issue since I am using NVDA in French; in this language, the unit is also called "point' and the abbreviation "pt" is used for it. It can be seen in Word when you get information for a style from the style management window. As an example, could you please indicate what would be the translated abbreviation in Bulgarian? I imagine it is written in Cyrillic? Are you able to see this abbreviation written somewhere, e.g. in Word's style definition? |
In bulgarian, the abbreviated variant of the font size unit is "пкт". The whole word is "пункта", which means "points". I thought that the information might be extracted directly (including locale names) from the program in which the command for formatting information is requested and therefore the issue might be caused by broken bulgarian localization in the specific program, but this occurs in every program that I've tested (both built-in and external ones) and this makes this theory highly unlikely. Unless, the information, although taken from the specific program, is provided by the system on a system level and the bulgarian localization for this is broken on a system level. But to be honest, I doubt it - I think this is just hard-coded in NVDA and it is not localizable at the moment. |
Yes, I have seen that it is hard-coded and not localizable in NVDA, at least for some applications or interface. I think that it could be localized quite easily. This issue may be a good canditate for labels such as "good for new dev" or "good first issue". If no one volunteers to fix this issue, I may have a look at it when I have more time. Feel free to ping me again. |
in slovenian there is simular problem. |
@gregjozk you write:
A similar bug, yes, but maybe not with the same type of cause. |
Fixes #13573 Summary of the issue: "pt" when reporting font size measurements is not translatable. Font size measurements are reported inconsistently, for example in excel and PowerPoint are reported as "11.0" instead of "11 pt". Description of how this pull request fixes the issue: Makes the font size measurement "pt" translatable across APIs. Browsers provide "font-size" attribute directly as "12pt|px|em|%|rem|ex" or "large", "small", etc. This requires a more strategic approach for catching each font-size case and replacing it with a translated string. Documentation has been added for this. https://developer.mozilla.org/en-US/docs/Web/CSS/font-size
Steps to reproduce:
Actual behavior:
NVDA reports the font size unit in english as "pt" (which means "points"), instead of in the language in which NVDA is set to.
Expected behavior:
NVDA should report the font size unit in the language in NVDA's interface language is set to.
System configuration
Other questions
Does the issue still occur after restarting your computer?
Yes, it does.
Have you tried any other versions of NVDA? If so, please report their behaviors.
Both the latest alpha build and 2021.3.5 behave the same.
If NVDA add-ons are disabled, is your problem still occurring?
Yes, it is.
Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?
I haven't tried it, because the issues that the COM Registration Fixing Tool aims to fix are not related to the issue I'm describing here.
The text was updated successfully, but these errors were encountered: