-
-
Notifications
You must be signed in to change notification settings - Fork 690
Indentation is not reported by NVDA in Visual Studio 2022 #13574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Also NVDA+F does not say the indentation level. |
Yes, true
… Also *NVDA+F* does not say the indentation level.
|
@LeonarddeR are you able to reproduce this? |
This is a known issue in Visual Studio. You will have to disable line numbers in Visual Studio's settings.
|
@LeonarddeR |
That's true, but it really is an issue in Visual Studio we can't work around. UIA has no native support to report line numbers. |
UIA may not have a native way to report line numbers, but the main issue here is that NVDA fails to report indentation when line numbers are enabled. Given that JAWS can (and they're using UIA for the editor control for some time now) closing this issue which clearly is an NVDA one feels wrong to me. |
@lukaszgo1 Absolutely, I'm completely with you on this. |
I agree that closing this issue was a bit too soon. Let's leave this open to investigate. |
Thanks @LeonarddeR for reopening. |
I'm pretty curious how JAWS behaves for a line like this when line numbers are disabled in visual studio: |
@LeonarddeR I'm thinking out loud and wanted to share it with you. The UIA and other Windows APIs eventually send NVDA the text with the focused text (in this case the line number and other code). Here is an example: 1 Console.WriteLine("text"); We will convert String to this: Console.WriteLine("text"); Isn't it a viable idea? |
The indentation is detected by means of a regular expression. We could implement something that expands that expression with numbers at the start of the line for Visual Studio, but then there's still the issue of what happens if line numbers are off in Visual Studio and a line starts with a number and white space. NV Access has always been very reluctant in accepting fixes like this, since they simply are ugly workarounds that could easily introduce other issues we don't know about beforehand. |
Actually, it looks like that a collapsed range at the start of a line will return the line number with a space. We should be able to separate the line number from the text that way. |
Ugh I'm sorry again, this turned out to be so easy! See #13604 |
Closes #13574 Summary of the issue: In Visual Studio, when line number reporting is enabled in VS itself, line numbers are part of the text. Therefore they are reported regardless of NVDA's line reporting settings. This also causes indentation reporting to fail. Description of how this pull request fixes the issue: This pr isolates the line number from the text and ensures that it is reported appropriately when line number reporting in NVDA is on. Testing strategy: With line reporting enabled in Visual studio Ensure that line numbers are reported when enabled in NVDA Ensure that line numbers are not reported when disabled in NVDA
sadly it is not fixed in #13604 |
Likewise, none of the mentioned pr seems to have fixed the problem.
|
Uh oh!
There was an error while loading. Please reload this page.
Steps to reproduce:
Actual behavior:
NVDA doesn't report the indentation in Visual Studio 2022
Please hear the attached video for the demo on the issue.
Expected behavior:
Indentation should be reported as per user's chosen setting.
System configuration
NVDA installed/portable/running from source:
Installed
NVDA version:
NVDA version alpha-25106,153f5004
Windows version:
Windows 11 22H2 Insiders Build 22581.200
Name and version of other software in use when reproducing the issue:
Visual Studio 2022
Other information about your system:
N/A
Other questions
Does the issue still occur after restarting your computer?
Yes, always.
Have you tried any other versions of NVDA? If so, please report their behaviors.
Happens with all the versions, tried many alpha snapshots as well as stable builds.
If NVDA add-ons are disabled, is your problem still occurring?
Yes, always.
Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?
Yes and it is not applicable.
B4a929e18343547328839eaf4768e4e9f637846018183538226_2022-04-03_22-20-37.mp4
The text was updated successfully, but these errors were encountered: