Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVDA doesn't beep on Java Progress bars #13594

Closed
thgcode opened this issue Apr 8, 2022 · 1 comment · Fixed by #13595
Closed

NVDA doesn't beep on Java Progress bars #13594

thgcode opened this issue Apr 8, 2022 · 1 comment · Fixed by #13595
Labels
triaged Has been triaged, issue is waiting for implementation.
Milestone

Comments

@thgcode
Copy link
Contributor

thgcode commented Apr 8, 2022

Steps to reproduce:

Open a Java app that contains a progress bar (for example I tested with this gist https://gist.github.com/brunosantanati/3c9e5778ba591b6218b6a210da1fc17f or Intellij).

Actual behavior:

NVDA does not beep or speak the percentage when it finds a Java progress bar.

Expected behavior:

NVDA should beep or speak on the progress bar, depending on the progress bar setting set.

System configuration

NVDA installed/portable/running from source:

I tested with installed 2021.3.3 and source-master-c446688 and on both the bug occurs.

NVDA version:

Tested on 2021.3.3 and on source-master-c446688.

Windows version:

Tested with Windows 10 1903, but since it's a Java issue it might occur on previor or later versions of Windows.

Name and version of other software in use when reproducing the issue:

Tested with Java 11.0.14.1 (Intellij) and Java 17.0.2 (example gist).

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

Yes.

Have you tried any other versions of NVDA? If so, please report their behaviors.

I tried both 2021.3.3 and source-master-c446688, it still occurs.

If NVDA add-ons are disabled, is your problem still occurring?

Yes.

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Since it was a bug on the access bridge handling code, I did not run it, but I imagine it does.

@thgcode
Copy link
Contributor Author

thgcode commented Apr 8, 2022

I will send a pull request for this issue, I created the issue to send the pull request.

thgcode added a commit to thgcode/nvda that referenced this issue Apr 8, 2022
@feerrenrut feerrenrut added the triaged Has been triaged, issue is waiting for implementation. label Apr 12, 2022
seanbudd pushed a commit that referenced this issue Apr 21, 2022
fixes #13594

Summary of the issue:
Currently, NVDA does not beep on Java progress bars. This happens because the progress bar is not added to the overlay classes when Java sends the "progress bar" role to NVDA.

Description of how this pull request fixes the issue:
This pull request adds the missing ProgressBar class when it detects the "progress bar" role.
@nvaccessAuto nvaccessAuto added this to the 2022.2 milestone Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants