-
-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Terminal: Leverage new UI Automation notifications support #13781
Comments
CC @carlos-zamora. |
I guess this is currently blocked by the fact that we can't yet distinguish between a terminal with and without notifications at the time of initializing the overlay classes. |
Per official word from the Windows Terminal team (CCing @DHowett), NVDA should always assume that Windows Terminal supports notifications, since all versions that don't are now unsupported. I think we can now consider this unblocked. I'm officially out of time to work on this issue (I start work on Microsoft Accessibility Insights later today), but I'll leave a few notes here if someone picks it up. Happy to review PRs and provide guidance where allowed by Microsoft policies.
|
According to microsoft/terminal#13601 (comment), all WT versions that are currently supported have UIA notifications implemented. Therefore it is safe to drop the older approach for Windows Terminal, at least for NVDA 2022.4 and newer. |
…ng for new text (#14047) Closes #13781 Summary of the issue: Windows Terminal supports UIA notification events to notify of new text. This is way quicker than the current diffing we use to calculate new text to speak in a terminal. Description of user facing changes Note: This is hidden behind a feature flag. When enabled, this should improve responsivity whereas having minimal user impact. The only thing I noticed is that when typing echo is on, the last typed character/word is spoken after pressing enter, whereas in the old situation, the last typed char/word was always silenced. I'd say this is an improvement. Description of development approach Handle the Windows Terminal object as regular Editable Text, i.e. remove the terminal specific stuff from it.
Is your feature request related to a problem? Please describe.
With microsoft/terminal#12358,
wt
now sends UIA notifications containing new text written to the terminal. To prevent conflict with our existingLiveText
implementation, NVDA PR #13261 ignores these notifications. However, replacingLiveText
with UIA notifications eliminates NVDA's need to diff the terminal (and possibly the need to listen totextChange
events), increasing performance and stability. See related issue #11002 (which is significantly improved when switching to UIA notifications).Describe the solution you'd like
Consider rethinking how NVDA interacts with Windows Terminal:
LiveText
and instead create a new, separate class for these terminals supporting UIA notifications.textChange
any more (i.e. stop following theEnhancedTermTypedCharSupport
approach), consider a new way to detect when typed characters aren't being echoed to the screen (i.e. don't speak typed passwords).Describe alternatives you've considered
Make no modifications.
The text was updated successfully, but these errors were encountered: