Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report "has details" in braille for non-landmark content #13815

Closed
seanbudd opened this issue Jun 20, 2022 · 0 comments · Fixed by #14425
Closed

Report "has details" in braille for non-landmark content #13815

seanbudd opened this issue Jun 20, 2022 · 0 comments · Fixed by #14425
Labels
ARIA component/braille p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone
2023.1

Comments

@seanbudd
Copy link
Member

Discovered in #13649

Steps to reproduce:

There is uneven behaviour between details reporting for speech and braille.
The following will report "has details" in speech but not braille:

<div><span aria-details="foo">bar</span></div>
<div id="foo">details of bar</div>

The following will report "has details" in both speech and braille:

<div><mark aria-details="foo">bar</mark></div>

<span aria-details="foo" role="form">bar</span>

<div id="foo">details of bar</div>

Actual behavior:

Some html nodes will not report "has details" in braille. It is suspected that this problem occurs for all non-landmark nodes.

Expected behavior:

Has details is reported consistently across braille and speech

System configuration

NVDA installed/portable/running from source:

NVDA version:

NVDA 2022.1
@seanbudd seanbudd added the ARIA label Jun 20, 2022
@seanbudd seanbudd mentioned this issue Jun 20, 2022
Merged
5 tasks
@seanbudd seanbudd added component/braille p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. labels Jun 28, 2022
feerrenrut added a commit that referenced this issue Dec 7, 2022
@feerrenrut
braille report 'has details' for non-landmarks
8e12fa6 
Fixes #13815
@feerrenrut feerrenrut mentioned this issue Dec 7, 2022
Merged
6 tasks
feerrenrut added a commit that referenced this issue Dec 7, 2022
@feerrenrut
braille hasDetails for non-landmark
a289dd8 
Fixes #13815

This can be squashed into commit: "Convert detailsRole to detailsRoles"
when rebasing on master.
feerrenrut added a commit that referenced this issue Dec 7, 2022
@feerrenrut
braille hasDetails for non-landmark
95ef705 
Fixes #13815

This can be squashed into commit: "Convert detailsRole to detailsRoles"
when rebasing on master.
feerrenrut added a commit that referenced this issue Dec 8, 2022
@feerrenrut
braille hasDetails for non-landmark
00122f4 
Fixes #13815

This can be squashed into commit: "Convert detailsRole to detailsRoles"
when rebasing on master.
feerrenrut added a commit that referenced this issue Dec 12, 2022
@feerrenrut
Braille: report 'details' for non-landmarks (PR #14425)
dc6ae59 
Fixes #13815

"details" was not reported with braille for some elements.
@nvaccessAuto nvaccessAuto modified the milestone: 2023.1 Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ARIA component/braille p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Milestone
2023.1
Development

Successfully merging a pull request may close this issue.

Braille: report 'details' for non-landmarks nvaccess/nvda
2 participants
@seanbudd @nvaccessAuto